Re: [PATCH 4/7] Add test of quota accounting using fsx

From: Dave Chinner <david@fromorbit.com>
To: Jan Kara <jack@suse.cz>
Cc: hch@infradead.org, xfs@oss.sgi.com
Subject: Re: [PATCH 4/7] Add test of quota accounting using fsx
Date: Thu, 20 May 2010 08:28:13 +1000	[thread overview]
Message-ID: <20100519222813.GN8120@dastard> (raw)
In-Reply-To: <1274276289-8839-5-git-send-email-jack@suse.cz>

On Wed, May 19, 2010 at 03:38:06PM +0200, Jan Kara wrote:
> Run fsx (and also several fsx threads in parallel) and verify that
> quota accounting is correct after they finish.
> 
> Signed-off-by: Jan Kara <jack@suse.cz>
> ---
>  231     |  139 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  231.out |   10 +++++
>  group   |    1 +
>  3 files changed, 150 insertions(+), 0 deletions(-)
>  create mode 100755 231
>  create mode 100644 231.out
> 
> diff --git a/231 b/231
> new file mode 100755
> index 0000000..0e34d33
> --- /dev/null
> +++ b/231
> @@ -0,0 +1,139 @@
> +#! /bin/bash
> +# FSQA Test No. 231
> +#
> +# Run fsx with quotas enabled and verify accounted quotas in the end
> +#
> +# Derived from test 127
> +#-----------------------------------------------------------------------
> +# Copyright (c) 2006 Silicon Graphics, Inc.  All Rights Reserved.
> +#
> +# This program is free software; you can redistribute it and/or
> +# modify it under the terms of the GNU General Public License as
> +# published by the Free Software Foundation.
> +#
> +# This program is distributed in the hope that it would be useful,
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +# GNU General Public License for more details.
> +#
> +# You should have received a copy of the GNU General Public License
> +# along with this program; if not, write the Free Software Foundation,
> +# Inc.,  51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
> +#
> +#-----------------------------------------------------------------------
> +#
> +# creator
> +owner=jack@suse.cz
> +
> +seq=`basename $0`
> +echo "QA output created by $seq"
> +
> +here=`pwd`
> +tmp=/tmp/$$
> +status=1	# failure is the default!
> +trap "rm -f $tmp.*; exit \$status" 0 1 2 3 15
> +
> +# get standard environment, filters and checks
> +. ./common.rc
> +. ./common.filter
> +. ./common.quota
> +
> +FSX_FILE_SIZE=64000000
> +FSX_ARGS="-q -l $FSX_FILE_SIZE -o 65536 -S 191110531 -N 20000"

My only question about this test is the use of a fixed seed for the
test - shouldn't we randomise it and save the seed to $seq.full?
This will results in different combinations of operations being
tested (better long term coverage), but we still have the seed
available to try to reproduce failures if they are based on a
specific pattern of ops...

As it stands, this would still be fine with a fixed seed...

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs