From: Christoph Hellwig <hch@infradead.org>
To: Jan Kara <jack@suse.cz>
Cc: Christoph Hellwig <hch@infradead.org>, xfs@oss.sgi.com
Subject: Re: [PATCH 2/7] Fix test whether kernel supports quotas
Date: Thu, 20 May 2010 11:05:55 -0400 [thread overview]
Message-ID: <20100520150555.GB27124@infradead.org> (raw)
In-Reply-To: <20100520124902.GB3395@quack.suse.cz>
On Thu, May 20, 2010 at 02:49:02PM +0200, Jan Kara wrote:
> On Wed 19-05-10 14:42:25, Christoph Hellwig wrote:
> > On Wed, May 19, 2010 at 03:38:04PM +0200, Jan Kara wrote:
> > > For all 2.6 kernels presence of quota support in kernel can be detected by
> > > checking /proc/sys/fs/quota. This is actually more reliable than trying to
> > > mount a filesystem with quota options (for example because SCRATCH_DEV does
> > > not have to contain a filesystem type we are going to test).
> >
> > It's not actually correct. /proc/sys/fs/quota only gets registered by
> > fs/quota/dquot.c, which means it's not avaiable in a kernel that only
> > has XFS quotas.
> Ah, I was convinced that _require_quota() should check whether VFS
> quotas are enabled but apparently it should work also for XFS. So would
> test like below be OK?
>
> if [ $FSTYP = "xfs" ]; then
> [ -f /proc/fs/xfs/xqmstat ] || _notrun "Installed kernel does not support XFS quota"
> else
> [ -d /proc/sys/fs/quota ] || _notrun "Installed kernel does not support quota"
> fi
That would still fail for GFS2.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-05-20 15:03 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-19 13:38 [PATCH 0/7 V2] Quota tests for XFSQA Jan Kara
2010-05-19 13:38 ` [PATCH 1/7] xfstests: test extent size hints Jan Kara
2010-05-20 15:01 ` Christoph Hellwig
2010-05-20 17:14 ` Jan Kara
2010-05-19 13:38 ` [PATCH 2/7] Fix test whether kernel supports quotas Jan Kara
2010-05-19 18:42 ` Christoph Hellwig
2010-05-20 12:49 ` Jan Kara
2010-05-20 15:05 ` Christoph Hellwig [this message]
2010-05-20 16:53 ` Jan Kara
2010-05-19 13:38 ` [PATCH 3/7] Test basic quota enforcement Jan Kara
2010-05-20 15:11 ` Christoph Hellwig
2010-05-20 17:21 ` Jan Kara
2010-05-19 13:38 ` [PATCH 4/7] Add test of quota accounting using fsx Jan Kara
2010-05-19 22:28 ` Dave Chinner
2010-05-20 12:52 ` Jan Kara
2010-05-19 13:38 ` [PATCH 5/7] Add quota test with fsstress Jan Kara
2010-05-20 13:16 ` Dave Chinner
2010-05-20 13:22 ` Jan Kara
2010-05-19 13:38 ` [PATCH 6/7] Add quota accounting test when fsstress is run and quota limits are set low Jan Kara
2010-05-19 13:38 ` [PATCH 7/7] Add test of quota limit and info setting Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100520150555.GB27124@infradead.org \
--to=hch@infradead.org \
--cc=jack@suse.cz \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox