From: Jan Kara <jack@suse.cz>
To: Christoph Hellwig <hch@infradead.org>
Cc: Jan Kara <jack@suse.cz>, xfs@oss.sgi.com
Subject: Re: [PATCH 3/7] Test basic quota enforcement
Date: Thu, 20 May 2010 19:21:15 +0200 [thread overview]
Message-ID: <20100520172114.GG3395@quack.suse.cz> (raw)
In-Reply-To: <20100520151130.GC27124@infradead.org>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=utf-8, Size: 869 bytes --]
On Thu 20-05-10 11:11:30, Christoph Hellwig wrote:
> The golden output contains "/local/test1/file5" which appaears
> to be in your test fs. You need to do something like
>
> sed -e "s,$SCRATCH_MNT,SCRATCH_MNT,g"
>
> or
>
> sed -e "s,$T“T_MNT,TEST_MNT,g"
>
> to make the test portable. This probably applies to the other tests
> as well.
I have filter_scratch function for this in all tests. I just forgot to
filter output of touch(1) through it. It should be fixed now.
BTW: What is the purpose of 'status' variable? I set it to 1 if I want
the test to fail because diff found differences between accounted and
real usage. Is this correct? Actually, diff will also print the differences
to stdout so setting status probably shouldn't be needed. So is it preferred
to set status to 1 or leave it 0?
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
[-- Attachment #2: Type: text/plain, Size: 121 bytes --]
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-05-20 17:19 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-19 13:38 [PATCH 0/7 V2] Quota tests for XFSQA Jan Kara
2010-05-19 13:38 ` [PATCH 1/7] xfstests: test extent size hints Jan Kara
2010-05-20 15:01 ` Christoph Hellwig
2010-05-20 17:14 ` Jan Kara
2010-05-19 13:38 ` [PATCH 2/7] Fix test whether kernel supports quotas Jan Kara
2010-05-19 18:42 ` Christoph Hellwig
2010-05-20 12:49 ` Jan Kara
2010-05-20 15:05 ` Christoph Hellwig
2010-05-20 16:53 ` Jan Kara
2010-05-19 13:38 ` [PATCH 3/7] Test basic quota enforcement Jan Kara
2010-05-20 15:11 ` Christoph Hellwig
2010-05-20 17:21 ` Jan Kara [this message]
2010-05-19 13:38 ` [PATCH 4/7] Add test of quota accounting using fsx Jan Kara
2010-05-19 22:28 ` Dave Chinner
2010-05-20 12:52 ` Jan Kara
2010-05-19 13:38 ` [PATCH 5/7] Add quota test with fsstress Jan Kara
2010-05-20 13:16 ` Dave Chinner
2010-05-20 13:22 ` Jan Kara
2010-05-19 13:38 ` [PATCH 6/7] Add quota accounting test when fsstress is run and quota limits are set low Jan Kara
2010-05-19 13:38 ` [PATCH 7/7] Add test of quota limit and info setting Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100520172114.GG3395@quack.suse.cz \
--to=jack@suse.cz \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox