From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o4R6X6l0116859 for ; Thu, 27 May 2010 01:33:07 -0500 Received: from mx2.suse.de (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id A746212A0246 for ; Wed, 26 May 2010 23:37:18 -0700 (PDT) Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by cuda.sgi.com with ESMTP id mAAg3qAVUKanVSX6 for ; Wed, 26 May 2010 23:37:18 -0700 (PDT) Date: Thu, 27 May 2010 16:35:23 +1000 From: Nick Piggin Subject: Re: [PATCH 3/5] superblock: introduce per-sb cache shrinker infrastructure Message-ID: <20100527063523.GJ22536@laptop> References: <1274777588-21494-1-git-send-email-david@fromorbit.com> <1274777588-21494-4-git-send-email-david@fromorbit.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1274777588-21494-4-git-send-email-david@fromorbit.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Dave Chinner Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, xfs@oss.sgi.com T24gVHVlLCBNYXkgMjUsIDIwMTAgYXQgMDY6NTM6MDZQTSArMTAwMCwgRGF2ZSBDaGlubmVyIHdy b3RlOgo+IC0tLSBhL2ZzL3N1cGVyLmMKPiArKysgYi9mcy9zdXBlci5jCj4gQEAgLTM3LDYgKzM3 LDUwIEBACj4gIExJU1RfSEVBRChzdXBlcl9ibG9ja3MpOwo+ICBERUZJTkVfU1BJTkxPQ0soc2Jf bG9jayk7Cj4gIAo+ICtzdGF0aWMgaW50IHBydW5lX3N1cGVyKHN0cnVjdCBzaHJpbmtlciAqc2hy aW5rLCBpbnQgbnJfdG9fc2NhbiwgZ2ZwX3QgZ2ZwX21hc2spCj4gK3sKPiArCXN0cnVjdCBzdXBl cl9ibG9jayAqc2I7Cj4gKwlpbnQgY291bnQ7Cj4gKwo+ICsJc2IgPSBjb250YWluZXJfb2Yoc2hy aW5rLCBzdHJ1Y3Qgc3VwZXJfYmxvY2ssIHNfc2hyaW5rKTsKPiArCj4gKwkvKgo+ICsJICogRGVh ZGxvY2sgYXZvaWRhbmNlLiAgV2UgbWF5IGhvbGQgdmFyaW91cyBGUyBsb2NrcywgYW5kIHdlIGRv bid0IHdhbnQKPiArCSAqIHRvIHJlY3Vyc2UgaW50byB0aGUgRlMgdGhhdCBjYWxsZWQgdXMgaW4g Y2xlYXJfaW5vZGUoKSBhbmQgZnJpZW5kcy4uCj4gKwkgKi8KPiArCWlmICghKGdmcF9tYXNrICYg X19HRlBfRlMpKQo+ICsJCXJldHVybiAtMTsKPiArCj4gKwkvKgo+ICsJICogaWYgd2UgY2FuJ3Qg Z2V0IHRoZSB1bW91bnQgbG9jaywgdGhlbiB0aGVyZSdzIG5vIHBvaW50IGhhdmluZyB0aGUKPiAr CSAqIHNocmlua2VyIHRyeSBhZ2FpbiBiZWNhdXNlIHRoZSBzYiBpcyBiZWluZyB0b3JuIGRvd24u Cj4gKwkgKi8KPiArCWlmICghZG93bl9yZWFkX3RyeWxvY2soJnNiLT5zX3Vtb3VudCkpCj4gKwkJ cmV0dXJuIC0xOwo+ICsKPiArCWlmICghc2ItPnNfcm9vdCkgewo+ICsJCXVwX3JlYWQoJnNiLT5z X3Vtb3VudCk7Cj4gKwkJcmV0dXJuIC0xOwo+ICsJfQo+ICsKPiArCWlmIChucl90b19zY2FuKSB7 Cj4gKwkJLyogcHJvcG9ydGlvbiB0aGUgc2NhbiBiZXR3ZWVuIHRoZSB0d28gY2FjaGXRlSAqLwo+ ICsJCWludCB0b3RhbDsKPiArCj4gKwkJdG90YWwgPSBzYi0+c19ucl9kZW50cnlfdW51c2VkICsg c2ItPnNfbnJfaW5vZGVzX3VudXNlZCArIDE7Cj4gKwkJY291bnQgPSAobnJfdG9fc2NhbiAqIHNi LT5zX25yX2RlbnRyeV91bnVzZWQpIC8gdG90YWw7Cj4gKwo+ICsJCS8qIHBydW5lIGRjYWNoZSBm aXJzdCBhcyBpY2FjaGUgaXMgcGlubmVkIGJ5IGl0ICovCj4gKwkJcHJ1bmVfZGNhY2hlX3NiKHNi LCBjb3VudCk7Cj4gKwkJcHJ1bmVfaWNhY2hlX3NiKHNiLCBucl90b19zY2FuIC0gY291bnQpOwoK SG1tLCBhbiBpbnRlcmVzdGluZyBkeW5hbWljIHRoYXQgeW91J3ZlIGNoYW5nZWQgaXMgdGhhdCBw cmV2aW91c2x5CndlJ2Qgc2NhbiBkY2FjaGUgTFJVIHByb3BvcnRpb25hdGVseSB0byBwYWdlY2Fj aGUsIGFuZCB0aGVuIHNjYW4KaW5vZGUgTFJVIGluIHByb3BvcnRpb24gdG8gdGhlIGN1cnJlbnQg bnVtYmVyIG9mIHVudXNlZCBpbm9kZXMuCgpCdXQgd2UgY2FuIHRoaW5rIG9mIGlub2RlcyB0aGF0 IGFyZSBvbmx5IGluIHVzZSBieSB1bnVzZWQgKGFuZCBhZ2VkKQpkZW50cmllcyBhcyBlZmZlY3Rp dmVseSB1bnVzZWQgdGhlbXNlbHZlcy4gU28gdGhpcyBzZXF1ZW5jZSB1bmRlcgplc3RpbWF0ZXMg aG93IG1hbnkgaW5vZGVzIHRvIHNjYW4uIFRoaXMgY291bGQgYmlhcyBwcmVzc3VyZSBhZ2FpbnN0 CmRjYWNoZSBJJ2QgdGhpbmssIGVzcGVjaWFsbHkgY29uc2lkZXJpbmcgaW5vZGVzIGFyZSBmYXIg bGFyZ2VyIHRoYW4KZGVudHJpZXMuIE1heWJlIHJlcXVpcmUgMiBwYXNzZXMgdG8gZ2V0IHRoZSBp bm9kZXMgdW51c2VkIGludGhlCmZpcnN0IHBhc3MuCgpQYXJ0IG9mIHRoZSBwcm9ibGVtIGlzIHRo ZSBmdW5ueSBzaHJpbmtlciBBUEkuCgpUaGUgcmlnaHQgd2F5IHRvIGRvIGl0IGlzIHRvIGNoYW5n ZSB0aGUgc2hyaW5rZXIgQVBJIHNvIHRoYXQgaXQgcGFzc2VzCmRvd24gdGhlIGxydV9wYWdlcyBh bmQgc2Nhbm5lZCBpbnRvIHRoZSBjYWxsYmFjay4gRnJvbSB0aGVyZSwgdGhlCnNocmlua2VycyBj YW4gY2FsY3VsYXRlIHRoZSBhcHByb3ByaWF0ZSByYXRpbyBvZiBvYmplY3RzIHRvIHNjYW4uCk5v IG5lZWQgZm9yIDItY2FsbCBzY2hlbWUsIG5vIG5lZWQgZm9yIHNocmlua2VyLT5zZWVrcywgYW5k IHRoZQphYmlsaXR5IHRvIGNhbGN1bGF0ZSBhbiBhcHByb3ByaWF0ZSByYXRpbyBmaXJzdCBmb3Ig ZGNhY2hlLCBhbmQgKnRoZW4qCmZvciBpY2FjaGUuCgpBIGhlbHBlciBvZiBjb3Vyc2UgY2FuIGRv IHRoZSBjYWxjdWxhdGlvbiAoY29uc2lkZXJpbmcgdGhhdCBldmVyeQpkcml2ZXIgYW5kIHRoZWly IGRvZyB3aWxsIGRvIHRoZSB3cm9uZyB0aGluZyBpZiB3ZSBsZXQgdGhlbSA6KSkuCgp1bnNpZ25l ZCBsb25nIHNocmlua2VyX3NjYW4odW5zaWduZWQgbG9uZyBscnVfcGFnZXMsCgkJCXVuc2lnbmVk IGxvbmcgbHJ1X3NjYW5uZWQsCgkJCXVuc2lnbmVkIGxvbmcgbnJfb2JqZWN0cywKCQkJdW5zaWdu ZWQgbG9uZyBzY2FuX3JhdGlvKQp7Cgl1bnNpZ25lZCBsb25nIGxvbmcgdG1wID0gbnJfb2JqZWN0 czsKCgl0bXAgKj0gbHJ1X3NjYW5uZWQgKiAxMDA7Cglkb19kaXYodG1wLCAobHJ1X3BhZ2VzICog c2Nhbl9yYXRpbykgKyAxKTsKCglyZXR1cm4gKHVuc2lnbmVkIGxvbmcpdG1wOwp9CgpUaGVuIHRo ZSBzaHJpbmtlciBjYWxsYmFjayB3aWxsIGdvOgoJc2ItPnNfbnJfZGVudHJ5X3NjYW4gKz0gc2hy aW5rZXJfc2NhbihscnVfcGFnZXMsIGxydV9zY2FubmVkLAoJCQkJc2ItPnNfbnJfZGVudHJ5X3Vu dXNlZCwKCQkJCXZmc19jYWNoZV9wcmVzc3VyZSAqIFNFRUtTX1BFUl9ERU5UUlkpOwoJaWYgKHNi LT5zX25yX2RlbnRyeV9zY2FuID4gU0hSSU5LX0JBVENIKQoJCXBydW5lX2RjYWNoZSgpCgoJc2It PnNfbnJfaW5vZGVfc2NhbiArPSBzaHJpbmtlcl9zY2FuKGxydV9wYWdlcywgbHJ1X3NjYW5uZWQs CgkJCQlzYi0+c19ucl9pbm9kZXNfdW51c2VkLAoJCQkJdmZzX2NhY2hlX3ByZXNzdXJlICogU0VF S1NfUEVSX0lOT0RFKTsKCS4uLgoKV2hhdCBkbyB5b3UgdGhpbmsgb2YgdGhhdD8gU2VlaW5nIGFz IHdlJ3JlIGNoYW5naW5nIHRoZSBzaHJpbmtlciBBUEkKYW55d2F5LCBJJ2QgdGhpbmsgaXQgaXMg aGlnaCB0aW1lIHRvIGRvIHNvbXRoaW5nIGxpa2UgdGhpcy4KCgpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwp4ZnMgbWFpbGluZyBsaXN0Cnhmc0Bvc3Muc2dp LmNvbQpodHRwOi8vb3NzLnNnaS5jb20vbWFpbG1hbi9saXN0aW5mby94ZnMK