From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: fix might_sleep() warning when initialising per-ag tree
Date: Thu, 27 May 2010 08:21:49 -0400 [thread overview]
Message-ID: <20100527122149.GB14632@infradead.org> (raw)
In-Reply-To: <1274925493-31401-1-git-send-email-david@fromorbit.com>
On Thu, May 27, 2010 at 11:58:13AM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> The use of radix_tree_preload() only works if the radix tree was initialised
> without the __GFP_WAIT flag. The per-ag tree uses GFP_NOFS, so does not trigger
> allocation of new tree nodes from the preloaded array. Hence it enters the
> allocator with a spinlock held and triggers the might_sleep() warnings.
>
> Reported-by; Chris Mason <chris.mason@oracle.com>
> Signed-off-by: Dave Chinner <dchinner@redhat.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2010-05-27 12:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-27 1:58 [PATCH] xfs: fix might_sleep() warning when initialising per-ag tree Dave Chinner
2010-05-27 12:21 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100527122149.GB14632@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox