From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: remove lazy per-AG initialization
Date: Mon, 31 May 2010 09:09:15 +1000 [thread overview]
Message-ID: <20100530230915.GA13732@dastard> (raw)
In-Reply-To: <20100528175108.GA9421@infradead.org>
On Fri, May 28, 2010 at 01:51:08PM -0400, Christoph Hellwig wrote:
> Historically XFS initializes the allocator / inode allocator per-AG
> lazily, that is the first time this information is required. For
> filesystems that use lazy superblock counters (which is the default now)
> we already have to walk all AGs to initialize the superblock counters
> on an unclean shutdown.
Which is not common, so isn't frequently triggered in the normal
mount process. The reason for the lazy initialisation is to speed
the mount process up when there are thousands of AGs. That is, we
avoid thousands of serialised IOs in the mount path. Have you
checked to see what the impact is on the clean mount execution time
is on such a filesystem?
FWIW, in the case of an unclean shutdown, we are already on the slow path
due to log recovery so adding IO to read all the headers it not such
a big deal as they have probably been read in during replay, anyway.
> This patch generalizes that code so that we
> always initialize the per-AG data on mount, and also during growfs so
> that we can remove all the special case code in the fastpath which
> couldn't assume that the per-AG data is already initialized.
I like the cleanup, but I'm not sure that potentially adding tens of
seconds to the time to mount a really large filesystem is a good
tradeoff...
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-05-30 23:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-28 17:51 [PATCH] xfs: remove lazy per-AG initialization Christoph Hellwig
2010-05-30 23:09 ` Dave Chinner [this message]
2010-06-03 21:58 ` Alex Elder
2010-06-04 1:42 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100530230915.GA13732@dastard \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox