[PATCH] xfstests 217: remove file in between mkfs's

[PATCH] xfstests 217: remove file in between mkfs's

[Eric Sandeen]

217 requires a 2G scratch:

_require_fs_space $SCRATCH_MNT 2202000

but as we mkfs different sizes, we actually are filling in the
sparse loopback more and more, and 3.8G isn't enough to contain it.

If we remove & recreate the file between mkfs's it doesn't take
so much space ... I don't think it adds significantly to test time.

Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
---

diff --git a/217 b/217
index 19540ad..ed86a51 100755
--- a/217
+++ b/217
@@ -60,6 +60,9 @@ LOOP_MNT=$SCRATCH_MNT/test_fs_dir
 _do_mkfs()
 {
 	for i in $*; do
+		# make large holey file
+		rm -f $LOOP_DEV
+		$XFS_IO_PROG -f -c "truncate 16383g" $LOOP_DEV
 		echo -n "fssize=${i}g "
 		$MKFS_XFS_PROG -f -b size=4096 -l version=2 \
 			-d name=$LOOP_DEV,size=${i}g |grep log

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] xfstests 217: remove file in between mkfs's

[Christoph Hellwig]

On Tue, Jun 08, 2010 at 10:28:12PM -0500, Eric Sandeen wrote:
> 217 requires a 2G scratch:
> 
> _require_fs_space $SCRATCH_MNT 2202000
> 
> but as we mkfs different sizes, we actually are filling in the
> sparse loopback more and more, and 3.8G isn't enough to contain it.
> 
> If we remove & recreate the file between mkfs's it doesn't take
> so much space ... I don't think it adds significantly to test time.
> 
> Signed-off-by: Eric Sandeen <sandeen@sandeen.net>

Looks good,


Reviewed-by: Christoph Hellwig <hch@lst.de>

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs