From: Christoph Hellwig <hch@lst.de>
To: Andi Kleen <andi@firstfloor.org>
Cc: ak@linux.intel.com, hch@lst.de, dgc@fromorbit.com, xfs@oss.sgi.com
Subject: Re: [PATCH] XFS: Fix gcc 4.6 set but not read and unused statement warnings v2
Date: Mon, 14 Jun 2010 10:30:21 +0200 [thread overview]
Message-ID: <20100614083021.GA29354@lst.de> (raw)
In-Reply-To: <20100614081356.GA27499@basil.fritz.box>
On Mon, Jun 14, 2010 at 10:13:56AM +0200, Andi Kleen wrote:
> - /* REFERENCED */
> - xfs_da_blkinfo_t *blkinfo;
> xfs_da_args_t *args;
> xfs_dablk_t child;
> xfs_dabuf_t *bp;
> @@ -742,15 +738,14 @@ xfs_da_root_join(xfs_da_state_t *state,
> if (error)
> return(error);
> ASSERT(bp != NULL);
> - blkinfo = bp->data;
> if (be16_to_cpu(oldroot->hdr.level) == 1) {
> - ASSERT(be16_to_cpu(blkinfo->magic) == XFS_DIR2_LEAFN_MAGIC ||
> - be16_to_cpu(blkinfo->magic) == XFS_ATTR_LEAF_MAGIC);
> + ASSERT(be16_to_cpu(bp->data->magic) == XFS_DIR2_LEAFN_MAGIC ||
> + be16_to_cpu(bp->data->magic) == XFS_ATTR_LEAF_MAGIC);
> } else {
> - ASSERT(be16_to_cpu(blkinfo->magic) == XFS_DA_NODE_MAGIC);
> + ASSERT(be16_to_cpu(bp->data->magic) == XFS_DA_NODE_MAGIC);
How can this work? bp->data is a void pointer.
> @@ -174,7 +173,6 @@ _xfs_filestream_pick_ag(
> /* Keep track of the AG with the most free blocks. */
> if (pag->pagf_freeblks > maxfree) {
> maxfree = pag->pagf_freeblks;
> - max_streams = atomic_read(&pag->pagf_fstrms);
> max_ag = ag;
> }
>
> @@ -196,8 +194,6 @@ _xfs_filestream_pick_ag(
> (flags & XFS_PICK_LOWSPACE))) {
>
> /* Break out, retaining the reference on the AG. */
> - free = pag->pagf_freeblks;
> - streams = atomic_read(&pag->pagf_fstrms);
These are used by the tracing code not yet converted to the new tracing
infrastructure. I think I'll prefer to just add the new tracing code
ASAP to make the warnings go away.
> break;
> }
> @@ -364,7 +358,8 @@ xfs_fstrm_free_func(
> /* Drop the reference taken on the AG when the item was added. */
> ref = xfs_filestream_put_ag(ip->i_mount, item->ag);
>
> - ASSERT(ref >= 0);
> + if (ref < 0)
> + ASSERT(0);
We never use the return value of xfs_filestream_put_ag, so we an just
make it return void (and move it to xfs_filestreams.c while at it).
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-06-14 8:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-14 8:13 [PATCH] XFS: Fix gcc 4.6 set but not read and unused statement warnings v2 Andi Kleen
2010-06-14 8:30 ` Christoph Hellwig [this message]
2010-06-14 8:59 ` Andi Kleen
2010-06-14 12:48 ` Christoph Hellwig
2010-06-14 13:39 ` Andi Kleen
2010-06-14 16:31 ` Andi Kleen
2010-06-15 0:54 ` Dave Chinner
2010-06-15 7:24 ` Andi Kleen
2010-06-16 2:48 ` Eric Sandeen
2010-06-16 7:33 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100614083021.GA29354@lst.de \
--to=hch@lst.de \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=dgc@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox