From: Andi Kleen <andi@firstfloor.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Andi Kleen <ak@linux.intel.com>, Andi Kleen <andi@firstfloor.org>,
dgc@fromorbit.com, xfs@oss.sgi.com
Subject: Re: [PATCH] XFS: Fix gcc 4.6 set but not read and unused statement warnings v2
Date: Mon, 14 Jun 2010 15:39:58 +0200 [thread overview]
Message-ID: <20100614133958.GH17092@basil.fritz.box> (raw)
In-Reply-To: <20100614124804.GA8547@lst.de>
On Mon, Jun 14, 2010 at 02:48:04PM +0200, Christoph Hellwig wrote:
> On Mon, Jun 14, 2010 at 10:59:33AM +0200, Andi Kleen wrote:
> > >How can this work? bp->data is a void pointer.
> >
> > It compiled with CONFIG_XFS_DEBUG enabled. Do I need to set some other
> > option to test this?
>
> It fails for me in a normal CONFIG_XFS_DEBUG build:
>
> fs/xfs/xfs_da_btree.c: In function 'xfs_da_root_join':
> fs/xfs/xfs_da_btree.c:737: warning: dereferencing 'void *' pointer
> fs/xfs/xfs_da_btree.c:737: error: request for member 'magic' in
> something not a structure or union
> fs/xfs/xfs_da_btree.c:737: warning: dereferencing 'void *' pointer
Hmm, it really compiled here (scratching head)
% grep XFS .config
CONFIG_XFS_FS=m
# CONFIG_XFS_QUOTA is not set
CONFIG_XFS_POSIX_ACL=y
# CONFIG_XFS_RT is not set
CONFIG_XFS_DEBUG=y
% make CC=gcc46 SUBDIRS=fs/xfs
LD fs/xfs/built-in.o
CC [M] fs/xfs/linux-2.6/xfs_trace.o
CC [M] fs/xfs/linux-2.6/xfs_acl.o
CC [M] fs/xfs/linux-2.6/xfs_stats.o
CC [M] fs/xfs/linux-2.6/xfs_sysctl.o
CC [M] fs/xfs/linux-2.6/xfs_ioctl32.o
CC [M] fs/xfs/xfs_alloc.o
CC [M] fs/xfs/xfs_alloc_btree.o
CC [M] fs/xfs/xfs_attr.o
CC [M] fs/xfs/xfs_attr_leaf.o
CC [M] fs/xfs/xfs_bit.o
CC [M] fs/xfs/xfs_bmap.o
CC [M] fs/xfs/xfs_bmap_btree.o
CC [M] fs/xfs/xfs_btree.o
CC [M] fs/xfs/xfs_buf_item.o
CC [M] fs/xfs/xfs_da_btree.o <---------------------------------
CC [M] fs/xfs/xfs_dir2.o
CC [M] fs/xfs/xfs_dir2_block.o
fs/xfs/xfs_dir2_block.c: In function 'xfs_dir2_sf_to_block':
fs/xfs/xfs_dir2_block.c:1153:26: warning: array subscript is above array bounds [-Warray-
bounds]
...
Do I need to set some other option?
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-06-14 13:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-14 8:13 [PATCH] XFS: Fix gcc 4.6 set but not read and unused statement warnings v2 Andi Kleen
2010-06-14 8:30 ` Christoph Hellwig
2010-06-14 8:59 ` Andi Kleen
2010-06-14 12:48 ` Christoph Hellwig
2010-06-14 13:39 ` Andi Kleen [this message]
2010-06-14 16:31 ` Andi Kleen
2010-06-15 0:54 ` Dave Chinner
2010-06-15 7:24 ` Andi Kleen
2010-06-16 2:48 ` Eric Sandeen
2010-06-16 7:33 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100614133958.GH17092@basil.fritz.box \
--to=andi@firstfloor.org \
--cc=ak@linux.intel.com \
--cc=dgc@fromorbit.com \
--cc=hch@lst.de \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox