From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Eric Sandeen <sandeen@sandeen.net>, xfs@oss.sgi.com
Subject: Re: [PATCH 1/3] xfs: fix corruption case for block size < page size
Date: Tue, 15 Jun 2010 11:21:15 +1000 [thread overview]
Message-ID: <20100615012114.GM6590@dastard> (raw)
In-Reply-To: <20100611161510.303551652@bombadil.infradead.org>
On Fri, Jun 11, 2010 at 12:13:13PM -0400, Christoph Hellwig wrote:
> From: Eric Sandeen <sandeen@sandeen.net>
>
> xfstests 194 first truncats a file back and then extends it again by
> truncating it to a larger size. This causes discard_buffer to drop
> the mapped, but not the uptodate bit and thus creates something that
> xfs_page_state_convert takes for unmapped space created by mmap because
> it doesn't check for the dirty bit, which also gets cleared by
> discard_buffer and checked by other ->writepage implementations like
> block_write_full_page. Handle this kind of buffers early, and unlike
> Eric's first version of the patch simply ASSERT that the buffers is
> dirty, given that the mmap write case can't happen anymore since the
> introduction of ->page_mkwrite. The now dead code dealing with that
> will be deleted in a follow on patch.
>
> Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Looks good.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-06-15 1:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-11 16:13 [PATCH 0/3] simplify the writeback code Christoph Hellwig
2010-06-11 16:13 ` [PATCH 1/3] xfs: fix corruption case for block size < page size Christoph Hellwig
2010-06-15 1:21 ` Dave Chinner [this message]
2010-06-11 16:13 ` [PATCH 2/3] xfs: simplify xfs_vm_releasepage Christoph Hellwig
2010-06-15 1:37 ` Dave Chinner
2010-06-15 6:22 ` Christoph Hellwig
2010-06-11 16:13 ` [PATCH 3/3] xfs: simplify xfs_vm_writepage Christoph Hellwig
2010-06-15 1:50 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100615012114.GM6590@dastard \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox