From: Andi Kleen <andi@firstfloor.org>
To: Dave Chinner <david@fromorbit.com>
Cc: Andi Kleen <ak@linux.intel.com>, Andi Kleen <andi@firstfloor.org>,
Christoph Hellwig <hch@lst.de>,
dgc@fromorbit.com, xfs@oss.sgi.com
Subject: Re: [PATCH] XFS: Fix gcc 4.6 set but not read and unused statement warnings v2
Date: Tue, 15 Jun 2010 09:24:52 +0200 [thread overview]
Message-ID: <20100615072452.GE6727@basil.fritz.box> (raw)
In-Reply-To: <20100615005442.GL6590@dastard>
> I'm still not happy with it.
With the BUG_ON?
>
> We'll commit a modified version of one of your patches into the XFS
> tree as you seem unable to accept that changes might be necessary to
> get your code to pass review.
Sure modify however you like as long as you fix the warnings.
Also it was good to have review on the cases it warned about,
luckily there were no real bugs found.
[BTW I should add there were some more mostly from array
overflows. I have not investigated in detail, but I suspect
they were harmless]
My goal was also mostly to get my build reasonably warning free,
but if I can't get this patch in I can also just disable the warning
for fs/xfs.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-06-15 7:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-14 8:13 [PATCH] XFS: Fix gcc 4.6 set but not read and unused statement warnings v2 Andi Kleen
2010-06-14 8:30 ` Christoph Hellwig
2010-06-14 8:59 ` Andi Kleen
2010-06-14 12:48 ` Christoph Hellwig
2010-06-14 13:39 ` Andi Kleen
2010-06-14 16:31 ` Andi Kleen
2010-06-15 0:54 ` Dave Chinner
2010-06-15 7:24 ` Andi Kleen [this message]
2010-06-16 2:48 ` Eric Sandeen
2010-06-16 7:33 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100615072452.GE6727@basil.fritz.box \
--to=andi@firstfloor.org \
--cc=ak@linux.intel.com \
--cc=david@fromorbit.com \
--cc=dgc@fromorbit.com \
--cc=hch@lst.de \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox