From: Christoph Hellwig <hch@infradead.org>
To: Dan Rosenberg <dan.j.rosenberg@gmail.com>
Cc: Christoph Hellwig <hch@infradead.org>,
security@kernel.org, xfs@oss.sgi.com,
Eugene Teo <eugeneteo@kernel.sg>,
aelder@sgi.com
Subject: Re: [Security] XFS swapext ioctl minor security issues
Date: Thu, 17 Jun 2010 07:40:51 -0400 [thread overview]
Message-ID: <20100617114051.GA13118@infradead.org> (raw)
In-Reply-To: <AANLkTimJHo3zfi0t96vVlTYgDswh8QtsptoTNkVK7Eb9@mail.gmail.com>
On Wed, Jun 16, 2010 at 09:57:35AM -0400, Dan Rosenberg wrote:
> I removed the part of the patch dealing with suid/sgid bits - your
> reasoning seems good, we clearly don't want to just drop the suid/sgid
> bits. ?I was just trying to point out the case where the caller is not
> the owner and has write access to the file; since in the ordinary case
> writing to that file would result in dropping the suid bit, I thought
> this ioctl should try to replicate that behavior.
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
Alex, can you push it to Linus ASAP?
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2010-06-17 11:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <AANLkTilrwmh6n7yYkqyvy_y5-bgS-BEDept0WlLg5GE1@mail.gmail.com>
[not found] ` <AANLkTikGFq8iv4S3QWp5ZCvXJsjuiP2tKweSl6QwHc6U@mail.gmail.com>
[not found] ` <20100616121142.GA22317@infradead.org>
2010-06-16 13:07 ` [Security] XFS swapext ioctl minor security issues Dan Rosenberg
2010-06-16 13:34 ` Christoph Hellwig
2010-06-16 13:57 ` Dan Rosenberg
2010-06-17 11:40 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100617114051.GA13118@infradead.org \
--to=hch@infradead.org \
--cc=aelder@sgi.com \
--cc=dan.j.rosenberg@gmail.com \
--cc=eugeneteo@kernel.sg \
--cc=security@kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox