From: Dave Chinner <david@fromorbit.com>
To: Michael Monnerie <michael.monnerie@is.it-management.at>
Cc: aelder@sgi.com, xfs@oss.sgi.com
Subject: Re: [PATCH] xfsqa: test open_by_handle() on unlinked and freed inode clusters V2
Date: Fri, 18 Jun 2010 08:51:30 +1000 [thread overview]
Message-ID: <20100617225130.GX6590@dastard> (raw)
In-Reply-To: <201006171007.26040@zmi.at>
On Thu, Jun 17, 2010 at 10:07:25AM +0200, Michael Monnerie wrote:
> On Donnerstag, 17. Juni 2010 Dave Chinner wrote:
> > Hence if we get a cold cache lookup from a stale handle that
> > references such an inode, we can read the inode off disk even though
> > it has been deleted because we don't check if the inode is allocated
> > or not. If the inode chunk has not been overwritten, then the inode
> > read will succeed and the handle-to-dentry conversion will not error
> > out like it is supposed to. The result is that stale NFS filehandles
> > and open_by_handle() will succeed incorrectly on unlinked files for
> > cold cache lookups.
>
> Wouldn't that qualify as a security problem and be handled as such?
> There should be back ports for "long term support" kernels of security-
> sensitive people, and so on.
Probably. Alex, are you able to handle this side of things?
Note that local open_by_handle() use is not really an issue - it
requires root and if you have root you can run xfs_db or dd on the
block device to get the same information.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-06-17 22:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-17 6:37 [PATCH] xfsqa: test open_by_handle() on unlinked and freed inode clusters V2 Dave Chinner
2010-06-17 8:07 ` Michael Monnerie
2010-06-17 22:51 ` Dave Chinner [this message]
2010-06-21 7:43 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2010-06-17 2:46 Dave Chinner
2010-06-17 5:56 ` Christoph Hellwig
2010-06-17 6:38 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100617225130.GX6590@dastard \
--to=david@fromorbit.com \
--cc=aelder@sgi.com \
--cc=michael.monnerie@is.it-management.at \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox