From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: security@kernel.org, xfs@oss.sgi.com
Subject: Re: [PATCH 3/4] xfs: rename XFS_IGET_BULKSTAT to XFS_IGET_UNTRUSTED
Date: Mon, 21 Jun 2010 03:21:59 -0400 [thread overview]
Message-ID: <20100621072159.GD1361@infradead.org> (raw)
In-Reply-To: <1277078341-19087-4-git-send-email-david@fromorbit.com>
On Mon, Jun 21, 2010 at 09:59:00AM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> Inode numbers may come from somewhere external to the filesystem
> (e.g. file handles, bulkstat information) and so are inherently
> untrusted. Rename the flag we use for these lookups to make it
> obvious we are doing a lookup of an untrusted inode number and need
> to verify it completely before trying to read it from disk.
>
> Signed-off-by: Dave Chinner <dchinner@redhat.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-06-21 7:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-20 23:58 [PATCH 0/4, V2] xfs: validate inode numbers in file handles correctly Dave Chinner
2010-06-20 23:58 ` [PATCH 1/4] xfs: always use iget in bulkstat Dave Chinner
2010-06-20 23:58 ` [PATCH 2/4] xfs: validate untrusted inode numbers during lookup Dave Chinner
2010-06-21 7:21 ` Christoph Hellwig
2010-06-20 23:59 ` [PATCH 3/4] xfs: rename XFS_IGET_BULKSTAT to XFS_IGET_UNTRUSTED Dave Chinner
2010-06-21 7:21 ` Christoph Hellwig [this message]
2010-06-20 23:59 ` [PATCH 4/4] xfs: remove block number from inode lookup code Dave Chinner
2010-06-21 7:22 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2010-06-18 7:32 xfs: validate inode numbers in file handles correctly Dave Chinner
2010-06-18 7:32 ` [PATCH 3/4] xfs: rename XFS_IGET_BULKSTAT to XFS_IGET_UNTRUSTED Dave Chinner
2010-06-18 11:42 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100621072159.GD1361@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=security@kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox