From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs_db: check for valid inode data pointer before dereferencing
Date: Sat, 26 Jun 2010 07:45:13 -0400 [thread overview]
Message-ID: <20100626114513.GB15157@infradead.org> (raw)
In-Reply-To: <1277418283-23381-1-git-send-email-david@fromorbit.com>
On Fri, Jun 25, 2010 at 08:24:43AM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> When processing an inode, the code checks various flags to determine
> whether to output messages or not. When checking the CLI provided
> inode numbers to be verbose about, we fail to check if the inode
> data structre returned is valid or not before dereferencing it.
> Hence running xfs_check with the "serious errors only" flag, xfs_db
> will crash. Fix up the "should we output" logic to be safe.
>
> Signed-off-by: Dave Chinner <dchinner@redhat.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2010-06-26 11:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-24 22:24 [PATCH] xfs_db: check for valid inode data pointer before dereferencing Dave Chinner
2010-06-26 11:45 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100626114513.GB15157@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox