From: Christoph Hellwig <hch@infradead.org>
To: xfs@oss.sgi.com
Subject: [PATCH] xfs: writepage always has buffers
Date: Mon, 28 Jun 2010 10:34:57 -0400 [thread overview]
Message-ID: <20100628143457.GC5473@infradead.org> (raw)
These days we always have buffers thanks to ->page_mkwrite. And we already
have an assert a few lines above tripping in case that was not true due to
a bug.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Index: xfs-dev/fs/xfs/linux-2.6/xfs_aops.c
===================================================================
--- xfs-dev.orig/fs/xfs/linux-2.6/xfs_aops.c 2010-06-28 11:59:29.590253914 +0200
+++ xfs-dev/fs/xfs/linux-2.6/xfs_aops.c 2010-06-28 11:59:48.341006462 +0200
@@ -1072,13 +1072,6 @@ xfs_vm_writepage(
if ((current->flags & PF_FSTRANS) && (delalloc || unwritten))
goto out_fail;
- /*
- * Delay hooking up buffer heads until we have
- * made our go/no-go decision.
- */
- if (!page_has_buffers(page))
- create_empty_buffers(page, 1 << inode->i_blkbits, 0);
-
/* Is this page beyond the end of the file? */
offset = i_size_read(inode);
end_index = offset >> PAGE_CACHE_SHIFT;
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next reply other threads:[~2010-06-28 14:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-28 14:34 Christoph Hellwig [this message]
2010-07-09 16:13 ` [PATCH] xfs: writepage always has buffers Christoph Hellwig
2010-07-12 3:43 ` Alex Elder
2010-07-12 16:05 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100628143457.GC5473@infradead.org \
--to=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox