From: Christoph Hellwig <hch@infradead.org>
To: Alex Elder <aelder@sgi.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 03/15] xfs: move DMAPI definitions out of "xfs_mount.h"
Date: Tue, 29 Jun 2010 09:35:00 -0400 [thread overview]
Message-ID: <20100629133500.GA11312@infradead.org> (raw)
In-Reply-To: <201006282204.o5SM4qbU018132@stout.americas.sgi.com>
On Mon, Jun 28, 2010 at 05:04:52PM -0500, Alex Elder wrote:
> XFS defines a bunch of DMAPI cruft in xfs_mount.h. There is no need
> for it to be there; move it instead into the xfs_dmapi.h file. A
> side-effect of this is that "xfs_dmapi.h" now depends on and needs
> to be #included after "xfs_mount.h" and "xfs_inode.h" (the latter of
> which itself depends on a "xfs_bmap_btree.h").
>
> On the other hand, "xfs_dmapi.h" is #included by a LOT more files
> than it needs to be, so eliminate those cases.
>
> Finally, "xfs_inode.h" defines a type dm_attrs_t that is never
> referenced anywhere else, so kill it off.
Asserting copyright on removing single include lines seems rather
interesting..
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-06-29 13:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-28 22:04 [PATCH 03/15] xfs: move DMAPI definitions out of "xfs_mount.h" Alex Elder
2010-06-29 13:35 ` Christoph Hellwig [this message]
2010-07-02 19:50 ` Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100629133500.GA11312@infradead.org \
--to=hch@infradead.org \
--cc=aelder@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox