From: Christoph Hellwig <hch@infradead.org>
To: Peter Watkins <treestem@gmail.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] Check block magic number so we scan only valid blocks.
Date: Wed, 7 Jul 2010 19:52:18 -0400 [thread overview]
Message-ID: <20100707235218.GA30851@infradead.org> (raw)
In-Reply-To: <1278515351-24928-1-git-send-email-treestem@gmail.com>
On Wed, Jul 07, 2010 at 11:09:11AM -0400, Peter Watkins wrote:
> Hello,
>
> Occasionally I've hit a SEGV while querying free space in xfs_db on a mounted
> file system. In scanfunc_bno, block->bb_numrecs has crazy values. And bb_magic
> is not XFS_ABTB_MAGIC.
>
> Does a check like this, similiar to other places, make sense?
Yes, it's reasonable. As long as you'd don't expect directly poking at
a life partition giving correct results..
> Should scanfunc_cnt make a similiar check?
Yes.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-07-07 23:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-07 15:09 [PATCH] Check block magic number so we scan only valid blocks Peter Watkins
2010-07-07 23:52 ` Christoph Hellwig [this message]
2010-07-08 19:20 ` Peter Watkins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100707235218.GA30851@infradead.org \
--to=hch@infradead.org \
--cc=treestem@gmail.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox