From: Christoph Hellwig <hch@infradead.org>
To: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: allow writeback from kswapd
Date: Fri, 9 Jul 2010 12:13:29 -0400 [thread overview]
Message-ID: <20100709161329.GC26302@infradead.org> (raw)
In-Reply-To: <20100628143444.GB5473@infradead.org>
ping?
On Mon, Jun 28, 2010 at 10:34:44AM -0400, Christoph Hellwig wrote:
> We only need disable I/O from direct or memcg reclaim.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> Index: xfs-dev/fs/xfs/linux-2.6/xfs_aops.c
> ===================================================================
> --- xfs-dev.orig/fs/xfs/linux-2.6/xfs_aops.c 2010-06-28 11:57:06.652261386 +0200
> +++ xfs-dev/fs/xfs/linux-2.6/xfs_aops.c 2010-06-28 11:59:17.846068204 +0200
> @@ -1049,16 +1049,15 @@ xfs_vm_writepage(
> /*
> * Refuse to write the page out if we are called from reclaim context.
> *
> - * This is primarily to avoid stack overflows when called from deep
> - * used stacks in random callers for direct reclaim, but disabling
> - * reclaim for kswap is a nice side-effect as kswapd causes rather
> - * suboptimal I/O patters, too.
> + * This avoids stack overflows when called from deeply used stacks in
> + * random callers for direct reclaim or memcg reclaim. We explicitly
> + * allow reclaim from kswapd as the stack usage there is relatively low.
> *
> * This should really be done by the core VM, but until that happens
> * filesystems like XFS, btrfs and ext4 have to take care of this
> * by themselves.
> */
> - if (current->flags & PF_MEMALLOC)
> + if ((current->flags & (PF_MEMALLOC|PF_KSWAPD)) == PF_MEMALLOC)
> goto out_fail;
>
> /*
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
---end quoted text---
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-07-09 16:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-28 14:34 [PATCH] xfs: allow writeback from kswapd Christoph Hellwig
2010-07-09 16:13 ` Christoph Hellwig [this message]
2010-07-12 3:37 ` Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100709161329.GC26302@infradead.org \
--to=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox