From: Christoph Hellwig <hch@infradead.org>
To: Alex Elder <aelder@sgi.com>
Cc: Christoph Hellwig <hch@infradead.org>, xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: writepage always has buffers
Date: Mon, 12 Jul 2010 12:05:23 -0400 [thread overview]
Message-ID: <20100712160523.GB2666@infradead.org> (raw)
In-Reply-To: <1278906189.7456.22.camel@doink>
On Sun, Jul 11, 2010 at 10:43:09PM -0500, Alex Elder wrote:
> On Mon, 2010-06-28 at 10:34 -0400, Christoph Hellwig wrote:
> > These days we always have buffers thanks to ->page_mkwrite. And we already
> > have an assert a few lines above tripping in case that was not true due to
> > a bug.
>
> Should the ASSERT() be made stronger (i.e., BUG_ON())?
> Looks to me like we'll crash if it ever happens in a
> non-debug kernel, and a BUG() call would more directly
> tell us what the problem was...
The crash tells it quite directly as well, the ASSERT is there more as
a documentation of what we require.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2010-07-12 16:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-28 14:34 [PATCH] xfs: writepage always has buffers Christoph Hellwig
2010-07-09 16:13 ` Christoph Hellwig
2010-07-12 3:43 ` Alex Elder
2010-07-12 16:05 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100712160523.GB2666@infradead.org \
--to=hch@infradead.org \
--cc=aelder@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox