From: Dave Chinner <david@fromorbit.com>
To: Eric Sandeen <sandeen@redhat.com>
Cc: Christoph Hellwig <hch@infradead.org>,
xfs mailing list <xfs@oss.sgi.com>
Subject: Re: [PATCH xfstests] _qmount: mount w/o selinux xattrs
Date: Tue, 13 Jul 2010 08:13:46 +1000 [thread overview]
Message-ID: <20100712221346.GI25335@dastard> (raw)
In-Reply-To: <4C3B6D0A.2010708@redhat.com>
On Mon, Jul 12, 2010 at 02:29:14PM -0500, Eric Sandeen wrote:
> On 07/09/2010 11:12 AM, Christoph Hellwig wrote
> > On Fri, Jul 02, 2010 at 12:48:55PM -0500, Eric Sandeen wrote:
> >>> What about just disabling selinux for all filesystems instead of just
> >>> XFS for the general case.
> >>
> >> Well it seems like if we -can- test with it on, that's good.
> >> Certain distros ship with it on by default, so exercising lots
> >> of scenarios with it on seems beneficial...
> >
> > It seems, but I'd rather do it consistently for all filesystems.
> >
>
> except we can't, because xfs actually has such low-level format checking
> that selinux -will- break it badly.
>
> I guess we could flag which tests can't run w/ extra xattrs,
> and only mount w/ the context for those?
Maybe use a group to define all the tests that can't run with
selinux enabled and check it before running each test? i.e. use
notrun to prevent such tests from running. The attr group isprobably
a good start for the tests that will break w/ selinux enabled....
Cheers.
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-07-12 22:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-01 19:58 [PATCH xfstests] _qmount: mount w/o selinux xattrs Eric Sandeen
2010-07-02 7:10 ` Christoph Hellwig
2010-07-02 17:48 ` Eric Sandeen
2010-07-09 16:12 ` Christoph Hellwig
2010-07-12 19:29 ` Eric Sandeen
2010-07-12 22:13 ` Dave Chinner [this message]
2010-07-13 16:40 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100712221346.GI25335@dastard \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=sandeen@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox