From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o6G5GbDN245935 for ; Fri, 16 Jul 2010 00:16:37 -0500 Received: from bombadil.infradead.org (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id BA78A45070B for ; Thu, 15 Jul 2010 22:19:34 -0700 (PDT) Received: from bombadil.infradead.org (bombadil.infradead.org [18.85.46.34]) by cuda.sgi.com with ESMTP id Yl9lj6PoZ8e3GCkz for ; Thu, 15 Jul 2010 22:19:34 -0700 (PDT) Date: Fri, 16 Jul 2010 01:19:34 -0400 From: Christoph Hellwig Subject: Re: [PATCH 3/5] xfs: fix xfs_trans_add_item() lockdep warnings Message-ID: <20100716051934.GC29915@infradead.org> References: <1279154300-2018-1-git-send-email-david@fromorbit.com> <1279154300-2018-4-git-send-email-david@fromorbit.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1279154300-2018-4-git-send-email-david@fromorbit.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Dave Chinner Cc: xfs@oss.sgi.com > - lidp = kmem_zone_zalloc(xfs_log_item_desc_zone, KM_SLEEP); > + lidp = kmem_zone_zalloc(xfs_log_item_desc_zone, KM_SLEEP|KM_NOFS); KM_NOFS by itself actually is sufficiant. If you want to keep the KM_SLEEP for documentation purposes at least add some spaces to make it more redable. lidp = kmem_zone_zalloc(xfs_log_item_desc_zone, KM_SLEEP | KM_NOFS); Once getting outside of nitpicking territory this looks good to me: Reviewed-by: Christoph Hellwig _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs