public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: Ilia Mirkin <imirkin@alum.mit.edu>
Cc: xfs@oss.sgi.com
Subject: Re: XFS hung on 2.6.33.3 kernel
Date: Mon, 19 Jul 2010 09:50:36 +1000	[thread overview]
Message-ID: <20100718235036.GC32635@dastard> (raw)
In-Reply-To: <AANLkTikEv75KRyRTs4awmG894NSKMnBkJNJPYsypMdWf@mail.gmail.com>

On Sat, Jul 17, 2010 at 09:35:33PM -0400, Ilia Mirkin wrote:
> On Sat, Jul 17, 2010 at 9:20 PM, Dave Chinner <david@fromorbit.com> wrote:
> > On Sat, Jul 17, 2010 at 12:01:11AM -0400, Ilia Mirkin wrote:
> > I can't find a thread that holds the XFS inode lock that everything
> > is waiting on. I think it is the ILOCK, but none of the threads in
> > this trace should be holding it where they are blocked. IOWs, the
> > output does not give me enough information to get to the root cause.
> 
> In case this happens again, was there something more useful I could
> have collected? Should I have grabbed all task states?

All the task states, including the running tasks, is probably a good
start. Also, if the kernel you are running has tracing events
enabled and has the necessary XFS tracepoints (I can't remember off
the top of my head whether they are in 2.6.33), you might want to
enable tracing of:

	xfs_ilock
	xfs_ilock_nowait
	xfs_ilock_demote
	xfs_iunlock

via:

# echo 1 > /sys/kernel/debug/tracing/events/xfs/<trace_point>/enable

and when the problem is hit dumping the trace via:

# cat /sys/kernel/debug/tracing/trace > trace.log

You may also want to bump up the trace buffer size to capture more
events:

# echo 32768 > /sys/kernel/debug/tracing/buffer_size_kb

Though I suspect the only way to get to the bottom of it will
be to work out a reproducable test case....

> It's pretty obvious that allowing userspace to hang the FS is really
> bad, but I appreciate that the app is doing something that the kernel
> didn't expect.

Yeah, we need to fix the hang - it's the bigger issues of mixed
direct/buffered IO that I was refering to...

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2010-07-18 23:47 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-17  4:01 XFS hung on 2.6.33.3 kernel Ilia Mirkin
2010-07-18  1:20 ` Dave Chinner
2010-07-18  1:35   ` Ilia Mirkin
2010-07-18 23:50     ` Dave Chinner [this message]
2010-08-03 22:30       ` Ilia Mirkin
2010-08-04  0:47         ` Dave Chinner
2010-08-04  1:15           ` Ilia Mirkin
2010-08-04  4:27             ` Dave Chinner
2010-08-04  4:39               ` Ilia Mirkin
2010-08-04  6:53                 ` Dave Chinner
2010-08-04 15:40                   ` Ilia Mirkin
2010-08-05  5:45                     ` Dave Chinner
2010-08-05  6:25         ` Dave Chinner
2010-08-05  6:42           ` Ilia Mirkin
2010-08-07 10:08             ` Dave Chinner
2013-04-04 21:44               ` qiyansun
2010-07-18  4:57   ` Christoph Hellwig
2010-07-18  5:28     ` Ilia Mirkin
2010-07-18 20:17       ` Ilia Mirkin
2010-07-18 23:33     ` Dave Chinner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100718235036.GC32635@dastard \
    --to=david@fromorbit.com \
    --cc=imirkin@alum.mit.edu \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox