From: Jan Kara <jack@suse.cz>
To: Christoph Hellwig <hch@infradead.org>
Cc: Jan Kara <jack@suse.cz>, xfs@oss.sgi.com
Subject: Re: [PATCH 2/2] Add test for correct $SCRATCH_MNT into _require_scratch
Date: Wed, 21 Jul 2010 19:32:25 +0200 [thread overview]
Message-ID: <20100721173224.GG3447@quack.suse.cz> (raw)
In-Reply-To: <20100721165428.GA1061@infradead.org>
[-- Attachment #1: Type: text/plain, Size: 259 bytes --]
On Wed 21-07-10 12:54:28, Christoph Hellwig wrote:
> This one is missing a signoff. Once you add it I can apply the series
> and push it out.
Oops sorry. Attached is the patch including the signoff.
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
[-- Attachment #2: 0002-Add-test-for-correct-SCRATCH_MNT-into-_require_scrat.patch --]
[-- Type: text/x-patch, Size: 683 bytes --]
>From d72c11b63aa22c920b460a71d4384c2f39be6513 Mon Sep 17 00:00:00 2001
From: Jan Kara <jack@suse.cz>
Date: Tue, 15 Jun 2010 10:54:12 +0200
Subject: [PATCH 2/2] Add test for correct $SCRATCH_MNT into _require_scratch
Signed-off-by: Jan Kara <jack@suse.cz>
---
common.rc | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/common.rc b/common.rc
index 6bf1e12..72997f9 100644
--- a/common.rc
+++ b/common.rc
@@ -703,6 +703,10 @@ _require_scratch()
then
_notrun "this test requires a valid \$SCRATCH_DEV"
fi
+ if [ ! -d "$SCRATCH_MNT" ]
+ then
+ _notrun "this test requires a valid \$SCRATCH_MNT"
+ fi
;;
esac
--
1.6.4.2
[-- Attachment #3: Type: text/plain, Size: 121 bytes --]
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-07-21 17:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-21 16:50 [PATCH 0/2 xfstests] Two improvements for xfstests Jan Kara
2010-07-21 16:50 ` [PATCH 1/2] Provide generic function for checking quota usage Jan Kara
2010-07-21 16:50 ` [PATCH 2/2] Add test for correct $SCRATCH_MNT into _require_scratch Jan Kara
2010-07-21 16:54 ` Christoph Hellwig
2010-07-21 17:32 ` Jan Kara [this message]
2010-07-21 17:35 ` Christoph Hellwig
2010-07-21 17:55 ` Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100721173224.GG3447@quack.suse.cz \
--to=jack@suse.cz \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox