From: Dave Chinner <david@fromorbit.com>
To: Michael Monnerie <michael.monnerie@is.it-management.at>
Cc: xfs@oss.sgi.com
Subject: Re: xfsprogs: CFLAGS not passed in
Date: Fri, 23 Jul 2010 08:29:00 +1000 [thread overview]
Message-ID: <20100722222900.GB32635@dastard> (raw)
In-Reply-To: <201007220821.44314@zmi.at>
On Thu, Jul 22, 2010 at 08:21:39AM +0200, Michael Monnerie wrote:
> I saw Christian Kujau's report yesterday with a quick fix, so maybe my
> reports of a similar problem have been missed in the thread "rsync and
> corrupt inodes (was xfs_dump problem)" and this is a repost:
>
> I tried to compile xfsprogs with the "CFLAGS":
> CFLAGS="-march=athlon64-sse3 -g -Os" ./configure --prefix=/usr
>
> No matter what I use for CFLAGS, the resulting binary repair/xfs_repair
> is always the same. So it seems to be ignored during compile anyway.
> Smells like a bug? Because config.status gets the CFLAGS set, it's just
> not used during compile. Comparing a "config.status" with CFLAGS set and
> without:
Yup, include/builddefs.in needs a line at the top something like:
CFLAGS = @CFLAGS@
To initialise CFLAGS to whatever configure decided it should be.
However, the way the flags are build in builddefs means that more
work than this is needed to allow the CFLAGS env variable to
override all the compile options that get added together....
e.g:
$ CFLAGS="-Os" ./configure
....
$ make Q=
....
gcc -MM -Os -I. -g -O2 -DNDEBUG -DVERSION=\"3.1.2\" -DLOCALEDIR=.....
....
The OPTIMIZER compile options are still included here, so there's
potential conflict just by dumbly initialising CFLAGS....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-07-22 22:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-22 6:21 xfsprogs: CFLAGS not passed in Michael Monnerie
2010-07-22 22:29 ` Dave Chinner [this message]
2010-07-23 6:16 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100722222900.GB32635@dastard \
--to=david@fromorbit.com \
--cc=michael.monnerie@is.it-management.at \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox