From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 1/2] xfs: use range primitives for xfs page cache operations
Date: Tue, 27 Jul 2010 02:53:26 -0400 [thread overview]
Message-ID: <20100727065326.GA32510@infradead.org> (raw)
In-Reply-To: <1280210129-10925-2-git-send-email-david@fromorbit.com>
On Tue, Jul 27, 2010 at 03:55:28PM +1000, Dave Chinner wrote:
> While XFS passes ranges to operate on from the core code, the
> functions being called ignore the either the entire range or the end
> of the range. This is historical because when the function were
> written linux didn't have the necessary range operations. Update the
> functions to use the correct operations.
Assuming you have actually tested this - given that we've ignore
these parameters so long that I'm really fearing some callers have
started to rely on that behaviour.
> if (mapping->nrpages) {
I'd drop this check ere as well - no other caller does it.
> xfs_iflags_clear(ip, XFS_ITRUNCATED);
> - ret = filemap_write_and_wait(mapping);
> + ret = filemap_write_and_wait_range(mapping, first,
> + last == -1 ? LLONG_MAX : last);
> if (!ret)
> - truncate_inode_pages(mapping, first);
> + truncate_inode_pages_range(mapping, first, last);
> }
> return -ret;
> }
> @@ -73,7 +71,8 @@ xfs_flush_pages(
>
> if (mapping_tagged(mapping, PAGECACHE_TAG_DIRTY)) {
Same for this check.
> xfs_iflags_clear(ip, XFS_ITRUNCATED);
> - ret = -filemap_fdatawrite(mapping);
> + ret = -filemap_fdatawrite_range(mapping, first,
> + last == -1 ? LLONG_MAX : last);
Also for the non-async case we should just use
filemap_write_and_wait_range, and kill off xfs_wait_on_pages.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-07-27 6:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-27 5:55 [RFC, PATCH 0/2] xfs: Fast zeroing of allocated space Dave Chinner
2010-07-27 5:55 ` [PATCH 1/2] xfs: use range primitives for xfs page cache operations Dave Chinner
2010-07-27 6:53 ` Christoph Hellwig [this message]
2010-07-27 12:05 ` Dave Chinner
2010-07-27 5:55 ` [PATCH 2/2] xfs: Introduce XFS_IOC_ZERO_RANGE Dave Chinner
2010-07-27 7:59 ` Christoph Hellwig
2010-07-27 20:49 ` [RFC, PATCH 0/2] xfs: Fast zeroing of allocated space Alex Elder
-- strict thread matches above, loose matches on Subject: below --
2010-08-03 6:22 [PATCH " Dave Chinner
2010-08-03 6:22 ` [PATCH 1/2] xfs: use range primitives for xfs page cache operations Dave Chinner
2010-08-03 18:56 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100727065326.GA32510@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox