From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: don't hold the XFS_ILOCK while flushing pages in swapext
Date: Tue, 27 Jul 2010 03:53:13 -0400 [thread overview]
Message-ID: <20100727075313.GB30562@infradead.org> (raw)
In-Reply-To: <1280209651-10800-1-git-send-email-david@fromorbit.com>
On Tue, Jul 27, 2010 at 03:47:31PM +1000, Dave Chinner wrote:
> +
> + /*
> + * can't hold the ILOCK while flushing pages, so flush now we won't get
> + * new pages cached as we hold the XFS_IOLOCK_EXCL.
> + */
> + if (VN_CACHED(VFS_I(tip)) != 0) {
There's really no point in the VN_CACHED check here. Not only does
xfs_flushinval_pages repeat it at the beginning, but it's also
rather superflous as filemap_write_and_wait deals with the condition
of no attached pages efficiently.
Otherwise looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-07-27 7:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-27 5:47 [PATCH] xfs: don't hold the XFS_ILOCK while flushing pages in swapext Dave Chinner
2010-07-27 7:53 ` Christoph Hellwig [this message]
2010-07-27 22:17 ` Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100727075313.GB30562@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox