* dmapi: fix depend targets
@ 2010-07-30 21:51 Alex Elder
2010-08-02 23:14 ` Dave Chinner
0 siblings, 1 reply; 2+ messages in thread
From: Alex Elder @ 2010-07-30 21:51 UTC (permalink / raw)
To: xfs
There's no need to re-make the dependency files all the time. Make
it so the "depend" target rebuilds the ".dep" file only if necessary.
Signed-off-by: Alex Elder <aelder@sgi.com>
---
include/buildrules | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
Index: b/include/buildrules
===================================================================
--- a/include/buildrules
+++ b/include/buildrules
@@ -8,7 +8,7 @@ include $(TOPDIR)/include/builddefs
clean clobber : $(addsuffix -clean,$(SUBDIRS))
rm -f $(DIRT)
- @rm -fr .libs
+ @rm -fr .libs .dep
%-clean:
$(MAKE) -C $* clean
@@ -72,9 +72,10 @@ ifdef LTLIBRARY
DEPENDSCRIPT := $(DEPENDSCRIPT) | $(SED) -e 's,^\([^:]*\)\.o,\1.lo,'
endif
-depend : $(CFILES) $(HFILES) $(addsuffix -depend,$(SUBDIRS))
+depend : .dep $(addsuffix -depend,$(SUBDIRS))
+
+.dep : $(CFILES) $(HFILES)
$(DEPENDSCRIPT) > .dep
- test -s .dep || rm -f .dep
%-depend:
$(MAKE) -C $* depend
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: dmapi: fix depend targets
2010-07-30 21:51 dmapi: fix depend targets Alex Elder
@ 2010-08-02 23:14 ` Dave Chinner
0 siblings, 0 replies; 2+ messages in thread
From: Dave Chinner @ 2010-08-02 23:14 UTC (permalink / raw)
To: Alex Elder; +Cc: xfs
On Fri, Jul 30, 2010 at 04:51:23PM -0500, Alex Elder wrote:
> There's no need to re-make the dependency files all the time. Make
> it so the "depend" target rebuilds the ".dep" file only if necessary.
>
> Signed-off-by: Alex Elder <aelder@sgi.com>
Reviewed-by: Dave Chinner <david@fromorbit.com>
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-08-02 23:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-07-30 21:51 dmapi: fix depend targets Alex Elder
2010-08-02 23:14 ` Dave Chinner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox