From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: dummy transactions should not dirty VFS state
Date: Tue, 3 Aug 2010 05:55:18 -0400 [thread overview]
Message-ID: <20100803095518.GA27470@infradead.org> (raw)
In-Reply-To: <1280826605-3506-1-git-send-email-david@fromorbit.com>
I looks good to me, but there are two subtile differences between
xfs_commit_dummy_trans and xfs_fs_log_dummy that get lost. For one
xfs_commit_dummy_trans doesn't actually commit a synchronous transaction
(or rather forces out the log) unless SYNC_WAIT is set, in addition
to that xfs_fs_log_dummy uses _xfs_trans_alloc, which doesn't get
blocked by the filesystem freezing.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-08-03 9:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-03 9:10 [PATCH] xfs: dummy transactions should not dirty VFS state Dave Chinner
2010-08-03 9:55 ` Christoph Hellwig [this message]
2010-08-03 12:07 ` Dave Chinner
2010-08-03 13:50 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100803095518.GA27470@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox