From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o739t0Hs235261 for ; Tue, 3 Aug 2010 04:55:01 -0500 Received: from bombadil.infradead.org (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id BEB11168928D for ; Tue, 3 Aug 2010 02:55:19 -0700 (PDT) Received: from bombadil.infradead.org (bombadil.infradead.org [18.85.46.34]) by cuda.sgi.com with ESMTP id DTTCpjsIuTQ6K2WK for ; Tue, 03 Aug 2010 02:55:19 -0700 (PDT) Date: Tue, 3 Aug 2010 05:55:18 -0400 From: Christoph Hellwig Subject: Re: [PATCH] xfs: dummy transactions should not dirty VFS state Message-ID: <20100803095518.GA27470@infradead.org> References: <1280826605-3506-1-git-send-email-david@fromorbit.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1280826605-3506-1-git-send-email-david@fromorbit.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Dave Chinner Cc: xfs@oss.sgi.com I looks good to me, but there are two subtile differences between xfs_commit_dummy_trans and xfs_fs_log_dummy that get lost. For one xfs_commit_dummy_trans doesn't actually commit a synchronous transaction (or rather forces out the log) unless SYNC_WAIT is set, in addition to that xfs_fs_log_dummy uses _xfs_trans_alloc, which doesn't get blocked by the filesystem freezing. _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs