From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: npiggin@kernel.de, xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: Reduce log force overhead for delayed logging
Date: Fri, 6 Aug 2010 09:01:06 -0400 [thread overview]
Message-ID: <20100806130106.GA16818@infradead.org> (raw)
In-Reply-To: <1280801234-23568-1-git-send-email-david@fromorbit.com>
Looks good to me,
Reviewed-by: Christoph Hellwig <hch@lst.de>
minor nitpicks below:
> int
> xlog_cil_push(
This can be marked STATIC now.
> +/*
> + * CIL force routines
> + */
> +xfs_lsn_t xlog_cil_force_lsn(struct log *log, xfs_lsn_t sequence);
> +
> +static inline void
> +xlog_cil_force(struct log *log)
> +{
> + if (log->l_cilp)
> + xlog_cil_force_lsn(log, log->l_cilp->xc_current_sequence);
> +}
I'd move the if (log->l_cilp) check to the caller. One of the two
already does so, as does the caller of xlog_cil_force_lsn.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2010-08-06 13:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-03 2:07 [PATCH] xfs: Reduce log force overhead for delayed logging Dave Chinner
2010-08-06 13:01 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100806130106.GA16818@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=npiggin@kernel.de \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox