From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfstests: fix NIS detection damage
Date: Fri, 6 Aug 2010 09:03:34 -0400 [thread overview]
Message-ID: <20100806130334.GC16818@infradead.org> (raw)
In-Reply-To: <1281057519-24730-1-git-send-email-david@fromorbit.com>
On Fri, Aug 06, 2010 at 11:18:39AM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> NIS detection wasn't tested on machines without NIS enabled, so many tests are
> failing on non-NIS machines. the _yp_active function has no specific return
> value so always evaluates as 0 (active) and the "_cat_passwd" function is
> called from within an awk script which is not valid as the shell may run with a
> sanitised environment. Hence the functions do not need specific export calls,
> either, as unsanitised subshells will automatically inherit the parent's
> environment.
>
> Signed-off-by: Dave Chinner <dchinner@redhat.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-08-06 13:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-06 1:18 [PATCH] xfstests: fix NIS detection damage Dave Chinner
2010-08-06 13:03 ` Christoph Hellwig [this message]
2010-08-10 13:44 ` Kinzel, David
2010-08-10 23:19 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100806130334.GC16818@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox