From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o76D3CnG141099 for ; Fri, 6 Aug 2010 08:03:12 -0500 Received: from bombadil.infradead.org (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 9148D49C587 for ; Fri, 6 Aug 2010 06:03:34 -0700 (PDT) Received: from bombadil.infradead.org (bombadil.infradead.org [18.85.46.34]) by cuda.sgi.com with ESMTP id qaFgvaOgXq94Lbgd for ; Fri, 06 Aug 2010 06:03:34 -0700 (PDT) Date: Fri, 6 Aug 2010 09:03:34 -0400 From: Christoph Hellwig Subject: Re: [PATCH] xfstests: fix NIS detection damage Message-ID: <20100806130334.GC16818@infradead.org> References: <1281057519-24730-1-git-send-email-david@fromorbit.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1281057519-24730-1-git-send-email-david@fromorbit.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Dave Chinner Cc: xfs@oss.sgi.com On Fri, Aug 06, 2010 at 11:18:39AM +1000, Dave Chinner wrote: > From: Dave Chinner > > NIS detection wasn't tested on machines without NIS enabled, so many tests are > failing on non-NIS machines. the _yp_active function has no specific return > value so always evaluates as 0 (active) and the "_cat_passwd" function is > called from within an awk script which is not valid as the shell may run with a > sanitised environment. Hence the functions do not need specific export calls, > either, as unsanitised subshells will automatically inherit the parent's > environment. > > Signed-off-by: Dave Chinner Looks good, Reviewed-by: Christoph Hellwig _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs