From: Christoph Hellwig <hch@infradead.org>
To: nathans@aconex.com
Cc: xfs <xfs@oss.sgi.com>
Subject: Re: Review: xfsprogs with libblkid enabled for Debian
Date: Thu, 19 Aug 2010 08:11:53 -0400 [thread overview]
Message-ID: <20100819121153.GB16045@infradead.org> (raw)
In-Reply-To: <86828409.114311282107988740.JavaMail.root@mail-au.aconex.com>
On Wed, Aug 18, 2010 at 03:06:28PM +1000, nathans@aconex.com wrote:
> Hi guys,
>
> Attached patch adds support for libblkid in Debian builds.
> There's a couple of other trivial things fixed up while the
> package was building - man page typos reported by lintian,
> fix source tarball generation (and deb build) when libblkid
> is enabled (*must* descend into libdisk to pick up sources)
> ... but its all pretty straight forward.
>
> I've checked that mkfs.xfs is linked as expected too. :)
All the changes in here look good, but I'd be much happier if you'd
submit separate changes with separate changelogs for the manpage
updates and the libdisk packaging fix.
As for the blkid-dev build-dep: we need at least version 2.17 of it
as that introduced the symbols we need, I think a versioned dependency
for this would be in order.
The doc/CHANGES update should include the names of external contributors
where applicable, and currently the release date for is set as part
of the release.sh process.
I'm fine with pushing out a new 3.1.3 release as it's time anyway, but
can we also include Dave's patch to add XFS_IOC_ZERO_RANGE support to
xfs_io and the xfsctl manpage first?
Next week also has Alex back from vacation, so I'd suggest waiting if
he has any input on this.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-08-19 12:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <472498892.114291282107960876.JavaMail.root@mail-au.aconex.com>
2010-08-18 5:06 ` Review: xfsprogs with libblkid enabled for Debian nathans
2010-08-18 11:48 ` Dave Chinner
2010-08-19 12:11 ` Christoph Hellwig [this message]
2010-08-19 21:41 ` Nathan Scott
2010-08-26 13:26 ` Nathan Scott
2010-08-30 14:21 ` Alex Elder
2010-08-30 19:51 ` Nathan Scott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100819121153.GB16045@infradead.org \
--to=hch@infradead.org \
--cc=nathans@aconex.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox