From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 2/2] xfs: improve buffer cache hash scalability
Date: Mon, 23 Aug 2010 06:36:47 -0400 [thread overview]
Message-ID: <20100823103647.GB7268@infradead.org> (raw)
In-Reply-To: <1282522546-7892-3-git-send-email-david@fromorbit.com>
> @@ -1443,8 +1438,7 @@ xfs_alloc_bufhash(
> {
> unsigned int i;
>
> - btp->bt_hashshift = external ? 3 : 8; /* 8 or 256 buckets */
> - btp->bt_hashmask = (1 << btp->bt_hashshift) - 1;
> + btp->bt_hashshift = external ? 3 : 12; /* 8 or 4096 buckets */
Not directly related to the patch, but we never have hashes buffers
on the log device. And on the RT device we only use hashed buffers
twice to verify the device size. With a little work on the latter
we can stop allocating the buf hash entirely for the RT and log
devices.
Anyway, the patch looks good for now, although we should try to get
rid of the hash long term.
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-08-23 10:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-23 0:15 [PATCH 0/2] xfs: Fix issues found doing large inode count testing Dave Chinner
2010-08-23 0:15 ` [PATCH 1/2] xfs: don't do memory allocation under the CIL context lock Dave Chinner
2010-08-23 10:32 ` Christoph Hellwig
2010-08-23 0:15 ` [PATCH 2/2] xfs: improve buffer cache hash scalability Dave Chinner
2010-08-23 10:36 ` Christoph Hellwig [this message]
2010-08-27 18:11 ` Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100823103647.GB7268@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox