From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: log IO completion workqueue is a high priority queue
Date: Wed, 8 Sep 2010 21:26:10 -0400 [thread overview]
Message-ID: <20100909012610.GA29825@infradead.org> (raw)
In-Reply-To: <1283936422-20160-1-git-send-email-david@fromorbit.com>
On Wed, Sep 08, 2010 at 07:00:22PM +1000, Dave Chinner wrote:
> queued ahead of all data/metadata IO completions and processed before the
> data/metadata completions. Hence the log never gets stalled, and operations
> needed to clean memory can continue as quickly as possible. This avoids the
> livelock conditions and allos the system to keep running under heavy load as
> per normal.
>From a quick review of how the WQ_HIGHPRI flag is handled this look good
to me. I'm still rather suspicious of the new workqueue code, and the
complete lack of documentation for it, though.
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2010-09-09 1:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-08 9:00 [PATCH] xfs: log IO completion workqueue is a high priority queue Dave Chinner
2010-09-09 1:26 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100909012610.GA29825@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox