From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o8EExVNh131397 for ; Tue, 14 Sep 2010 09:59:32 -0500 Received: from bombadil.infradead.org (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 6D210DD91A7 for ; Tue, 14 Sep 2010 08:12:06 -0700 (PDT) Received: from bombadil.infradead.org (bombadil.infradead.org [18.85.46.34]) by cuda.sgi.com with ESMTP id 3rW9HAbZbu8c4BfP for ; Tue, 14 Sep 2010 08:12:06 -0700 (PDT) Date: Tue, 14 Sep 2010 11:00:19 -0400 From: Christoph Hellwig Subject: Re: [PATCH 12/18] xfs: use unhashed buffers for size checks Message-ID: <20100914150019.GJ3400@infradead.org> References: <1284461777-1496-1-git-send-email-david@fromorbit.com> <1284461777-1496-13-git-send-email-david@fromorbit.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1284461777-1496-13-git-send-email-david@fromorbit.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Dave Chinner Cc: xfs@oss.sgi.com On Tue, Sep 14, 2010 at 08:56:11PM +1000, Dave Chinner wrote: > From: Dave Chinner > > When we are checking we can access the last block of each device, we > do not need to use cached buffers as they will be tossed away > immediately. Use uncached buffers for size checks so that all IO > prior to full in-memory structure initialisation does not use the > buffer cache. Looks good, Reviewed-by: Christoph Hellwig _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs