From: Christoph Hellwig <hch@infradead.org>
To: Alex Elder <aelder@sgi.com>
Cc: Poyo VL <poyo_vl@yahoo.com>, xfs@oss.sgi.com
Subject: Re: [PATCH] 2.6.35.4: Fixed simple warning (array subscript is above array bounds)
Date: Thu, 16 Sep 2010 12:48:35 -0400 [thread overview]
Message-ID: <20100916164835.GA19511@infradead.org> (raw)
In-Reply-To: <1284655322.2153.22.camel@doink>
On Thu, Sep 16, 2010 at 11:42:02AM -0500, Alex Elder wrote:
> Additionally, the alignment of the overall structure
> will be 64 bits because of hte inumber field. Expanding
> the name field by another byte will not change that.
>
> So I think this change is OK. Can anyone else
> back me up?
We do sizeof requests on a few of these structures, not sure if it
includes this one. I have a patchset to dust off that gets rid of
all the structures that aren't actually physically on disk. I'll
try to dust if off and submit it - this was a preparation for the
CRC enablement of the directory structures.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2010-09-16 16:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-02 9:10 [PATCH] 2.6.35.4: Fixed simple warning (array subscript is above array bounds) Poyo VL
2010-09-16 16:42 ` Alex Elder
2010-09-16 16:48 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100916164835.GA19511@infradead.org \
--to=hch@infradead.org \
--cc=aelder@sgi.com \
--cc=poyo_vl@yahoo.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox