From: Dave Chinner <david@fromorbit.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: sector size warning at mount time
Date: Fri, 17 Sep 2010 09:18:03 +1000 [thread overview]
Message-ID: <20100916231803.GH24409@dastard> (raw)
In-Reply-To: <4C92641F.7080504@sandeen.net>
On Thu, Sep 16, 2010 at 01:38:23PM -0500, Eric Sandeen wrote:
> On ppc64 I'm tripping this warning:
>
> if (verbose &&
> (PAGE_CACHE_SIZE / BITS_PER_LONG) > sectorsize) {
> printk(KERN_WARNING
> "XFS: %u byte sectors in use on device %s. "
> "This is suboptimal; %u or greater is ideal.\n",
> sectorsize, XFS_BUFTARG_NAME(btp),
> (unsigned int)PAGE_CACHE_SIZE / BITS_PER_LONG);
> }
>
> and it's telling me I should have 1024-byte sectors...
>
> If the kernel is going to complain at mount, should we get it right
> at mkfs time? I'm not even quite sure why it's recommending this?
Because it requires 128 bits to track each sector in page when the
buffer cache is has to use sub-page buffers. That's all the
test/set_region garbage that it has.
The don't-user-the-page-cache part of my buffer cache rework fixes
this bug, so I probably wouldn't bother changing anything else at this
point in time...
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2010-09-16 23:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-16 18:38 sector size warning at mount time Eric Sandeen
2010-09-16 23:18 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100916231803.GH24409@dastard \
--to=david@fromorbit.com \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox