[PATCH] xfstests: add local.config example

[PATCH] xfstests: add local.config example

[Eric Sandeen]

I think it'd be useful to have a local.config template in the
git repo, to avoid having to re-read the README each time
to remember the required environment variable names.

Thoughts?  Am I just lazy?  :)

Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
---

diff --git a/local.config b/local.config.example
new file mode 100644
index 0000000..6b2e0e9
--- /dev/null
+++ b/local.config.example
@@ -0,0 +1,10 @@
+# Ideally define at least these 4 to match your environment
+# The first 2 are required.
+# See README for other variables which can be set.
+#
+# Note: SCRATCH_DEV >will< get overwritten!
+
+export TEST_DEV=/dev/sdX1
+export TEST_DIR=/mnt/test
+export SCRATCH_DEV=/dev/sdX2
+export SCRATCH_MNT=/mnt/scratch

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] xfstests: add local.config example

[Dave Chinner]

On Thu, Sep 16, 2010 at 01:07:47PM -0500, Eric Sandeen wrote:
> I think it'd be useful to have a local.config template in the
> git repo, to avoid having to re-read the README each time
> to remember the required environment variable names.
> 
> Thoughts?  Am I just lazy?  :)

Lazy makes the world go round. ;)

A template is probably a good idea.

Reviewed-by: Dave Chinner <dchinner@redhat.com>

Btw, if you are going add a template, you might as well remove all
the old configs that are there. I don't think any of them exist
anymore, and they have no further use as templates.....

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: xfstests: add local.config example

[Rich Johnston]

On 09/16/2010 01:07 PM, Eric Sandeen wrote:
> I think it'd be useful to have a local.config template in the
> git repo, to avoid having to re-read the README each time
> to remember the required environment variable names.
>
> Thoughts?  Am I just lazy?  :)
>
> Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
> Reviewed-by: Dave Chinner <dchinner@redhat.com>
>
> ---

Looks good

Reviewed-by: Rich Johnston <rjohnston@sgi.com>

Eric,

This patch has been committed to git://oss.sgi.com/xfs/cmds/xfstests, 
master branch, commit ID ac996c66.

Thanks
--Rich

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs