From: Dave Chinner <david@fromorbit.com>
To: Mike Gao <ygao.linux@gmail.com>
Cc: xfs@oss.sgi.com
Subject: Re: The segment fault with NULL point using when recovering failure
Date: Fri, 17 Sep 2010 11:44:12 +1000 [thread overview]
Message-ID: <20100917014412.GK24409@dastard> (raw)
In-Reply-To: <AANLkTimR-dBLmQQ-Nh0mmjHJMfFidePKxfO6P76y48n8@mail.gmail.com>
On Wed, Sep 15, 2010 at 10:59:07AM -0500, Mike Gao wrote:
> xlog_recover_process_iunlinks(
> xlog_t *log)
> {
> /*
> * Reacquire the agibuffer and continue around
> * the loop. This should never fail as we know
> * the buffer was good earlier on.
> */
> error = xfs_read_agi(mp, NULL, agno, &agibp);
> ASSERT(error == 0);
> agi = XFS_BUF_TO_AGI(agibp);
>
> }
> If no defined DEBUG, ASSERT will not work and agibp could be ZERO if there
> is a error in xfs_read_agi.
> And the comment shouldn't say it never fail because xfs_read_agi will
> return error in function and it does when there is forced shutdown.
Have you seen a failure here?
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-09-17 1:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-15 15:59 The segment fault with NULL point using when recovering failure Mike Gao
2010-09-17 1:44 ` Dave Chinner [this message]
2010-09-24 15:53 ` Mike Gao
2010-09-29 6:05 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100917014412.GK24409@dastard \
--to=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
--cc=ygao.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox