From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o8H1hQjM029948 for ; Thu, 16 Sep 2010 20:43:26 -0500 Received: from mail.internode.on.net (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 7F6DC11E65A1 for ; Thu, 16 Sep 2010 18:56:14 -0700 (PDT) Received: from mail.internode.on.net (bld-mail12.adl6.internode.on.net [150.101.137.97]) by cuda.sgi.com with ESMTP id 2wV9YwH1jhyAC25X for ; Thu, 16 Sep 2010 18:56:14 -0700 (PDT) Date: Fri, 17 Sep 2010 11:44:12 +1000 From: Dave Chinner Subject: Re: The segment fault with NULL point using when recovering failure Message-ID: <20100917014412.GK24409@dastard> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Mike Gao Cc: xfs@oss.sgi.com On Wed, Sep 15, 2010 at 10:59:07AM -0500, Mike Gao wrote: > xlog_recover_process_iunlinks( > xlog_t *log) > { > /* > * Reacquire the agibuffer and continue around > * the loop. This should never fail as we know > * the buffer was good earlier on. > */ > error = xfs_read_agi(mp, NULL, agno, &agibp); > ASSERT(error == 0); > agi = XFS_BUF_TO_AGI(agibp); > > } > If no defined DEBUG, ASSERT will not work and agibp could be ZERO if there > is a error in xfs_read_agi. > And the comment shouldn't say it never fail because xfs_read_agi will > return error in function and it does when there is forced shutdown. Have you seen a failure here? Cheers, Dave. -- Dave Chinner david@fromorbit.com _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs