From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 12/16] xfs: implement batched inode lookups for AG walking
Date: Wed, 22 Sep 2010 13:33:06 -0400 [thread overview]
Message-ID: <20100922173306.GE5697@infradead.org> (raw)
In-Reply-To: <1285137869-10310-13-git-send-email-david@fromorbit.com>
> + int (*grab)(struct xfs_inode *ip),
I think we can do without this callback. The inode verification that
needs to be done is always the same. The only difference is that the
dqrele code skips the quota inodes - but this can easily be done in
the execute callback, and given that it's a slow path the additional
two igrab calls won't hurt either.
To be symmetic with that the IRELE call should also be moved from the
execute callbacks into the caller. All this is stuff enabled by
splitting out the reclaim code earlier which was pretty different in
this area. In fact just moving the validation + igrab and IRELE into
common code might just be done in a separate patch between the last one
and this.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-09-22 17:32 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-22 6:44 [PATCH 0/16] xfs: metadata scalability V2 Dave Chinner
2010-09-22 6:44 ` [PATCH 01/16] xfs: reduce the number of CIL lock round trips during commit Dave Chinner
2010-09-22 16:51 ` Christoph Hellwig
2010-09-22 19:57 ` Alex Elder
2010-09-22 6:44 ` [PATCH 02/16] xfs: remove debug assert for per-ag reference counting Dave Chinner
2010-09-22 6:44 ` [PATCH 03/16] xfs: lockless per-ag lookups Dave Chinner
2010-09-22 6:44 ` [PATCH 04/16] xfs: don't use vfs writeback for pure metadata modifications Dave Chinner
2010-09-22 17:24 ` Christoph Hellwig
2010-09-23 0:36 ` Dave Chinner
2010-09-23 16:19 ` Alex Elder
2010-09-22 6:44 ` [PATCH 05/16] xfs: rename xfs_buf_get_nodaddr to be more appropriate Dave Chinner
2010-09-22 17:25 ` Christoph Hellwig
2010-09-23 0:37 ` Dave Chinner
2010-09-23 16:22 ` Alex Elder
2010-09-22 6:44 ` [PATCH 06/16] xfs: introduced uncached buffer read primitve Dave Chinner
2010-09-22 6:44 ` [PATCH 07/16] xfs: store xfs_mount in the buftarg instead of in the xfs_buf Dave Chinner
2010-09-22 6:44 ` [PATCH 08/16] xfs: kill XBF_FS_MANAGED buffers Dave Chinner
2010-09-22 6:44 ` [PATCH 09/16] xfs: use unhashed buffers for size checks Dave Chinner
2010-09-22 6:44 ` [PATCH 10/16] xfs: remove buftarg hash for external devices Dave Chinner
2010-09-22 6:44 ` [PATCH 11/16] xfs: split inode AG walking into separate code for reclaim Dave Chinner
2010-09-22 17:28 ` Christoph Hellwig
2010-09-23 16:45 ` Alex Elder
2010-09-22 6:44 ` [PATCH 12/16] xfs: implement batched inode lookups for AG walking Dave Chinner
2010-09-22 17:33 ` Christoph Hellwig [this message]
2010-09-23 0:40 ` Dave Chinner
2010-09-23 17:17 ` Alex Elder
2010-09-24 9:15 ` Dave Chinner
2010-09-27 16:05 ` Alex Elder
2010-09-27 17:43 ` Alex Elder
2010-09-22 6:44 ` [PATCH 13/16] xfs: batch inode reclaim lookup Dave Chinner
2010-09-22 17:34 ` Christoph Hellwig
2010-09-23 0:43 ` Dave Chinner
2010-09-23 17:39 ` Alex Elder
2010-09-22 6:44 ` [PATCH 14/16] xfs: serialise inode reclaim within an AG Dave Chinner
2010-09-23 17:50 ` Alex Elder
2010-09-22 6:44 ` [PATCH 16/16] xfs; pack xfs_buf structure more tightly Dave Chinner
2010-09-22 14:53 ` [PATCH 0/16] xfs: metadata scalability V2 Christoph Hellwig
2010-09-22 20:55 ` Alex Elder
2010-09-23 0:46 ` [PATCH 15/16] xfs: convert buffer cache hash to rbtree Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100922173306.GE5697@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox