From: Christoph Hellwig <hch@infradead.org>
To: Arkadiusz Mi??kiewicz <arekm@maven.pl>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH VER 5] Extend project quotas to support 32bit project identifiers.
Date: Sat, 25 Sep 2010 20:05:46 -0400 [thread overview]
Message-ID: <20100926000546.GA18984@infradead.org> (raw)
In-Reply-To: <1285332677-13490-1-git-send-email-arekm@maven.pl>
> - if ((mask & FSX_PROJID) && (fa->fsx_projid > (__uint16_t)-1))
> + if ((mask & FSX_PROJID) && (fa->fsx_projid > (__uint16_t)-1)
> + && !xfs_sb_version_hasprojid32bit(&ip->i_mount->m_sb))
I hate to nipick now that this is basically ready, but the normal kernel
and XFS style is to keep the operators at the end of the previous line,
e.g.
if ((mask & FSX_PROJID) && (fa->fsx_projid > (__uint16_t)-1) &&
!xfs_sb_version_hasprojid32bit(&ip->i_mount->m_sb))
> --- a/fs/xfs/xfs_sb.h
> +++ b/fs/xfs/xfs_sb.h
> @@ -80,10 +80,12 @@ struct xfs_mount;
> #define XFS_SB_VERSION2_RESERVED4BIT 0x00000004
> #define XFS_SB_VERSION2_ATTR2BIT 0x00000008 /* Inline attr rework */
> #define XFS_SB_VERSION2_PARENTBIT 0x00000010 /* parent pointers */
> +#define XFS_SB_VERSION2_PROJID32BIT 0x00000020 /* 32 bit project id */
0x00000020 is already used by patches to make use inocode for the CI
dir hash, and 0x00000040 is used by the NFSv4 ACL patches. Can you take
0x00000080 instead?
I'll submit a patch to get the other two into the header so that they
won't conflict.
Except for these minor bits this looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2010-09-26 0:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-24 12:51 [PATCH VER 5] Extend project quotas to support 32bit project identifiers Arkadiusz Miśkiewicz
2010-09-24 12:52 ` [PATCH VER 5] xfsprogs: projid32bit handling Arkadiusz Miśkiewicz
2010-09-24 12:52 ` [PATCH VER 5] xfstests: Quota project id setting overflow Arkadiusz Miśkiewicz
2010-09-26 0:10 ` Christoph Hellwig
2010-09-24 20:17 ` [PATCH VER 5] xfsprogs: projid32bit handling (xfs_admin patch) Arkadiusz Miskiewicz
2010-09-26 0:06 ` [PATCH VER 5] xfsprogs: projid32bit handling Christoph Hellwig
2010-09-26 0:05 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100926000546.GA18984@infradead.org \
--to=hch@infradead.org \
--cc=arekm@maven.pl \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox