From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o8TBSuaj043625 for ; Wed, 29 Sep 2010 06:28:56 -0500 Received: from mail.internode.on.net (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 8BE03E9130C for ; Wed, 29 Sep 2010 04:42:59 -0700 (PDT) Received: from mail.internode.on.net (bld-mail12.adl6.internode.on.net [150.101.137.97]) by cuda.sgi.com with ESMTP id B6zKEYiZxSsBykFu for ; Wed, 29 Sep 2010 04:42:59 -0700 (PDT) Date: Wed, 29 Sep 2010 21:29:20 +1000 From: Dave Chinner Subject: Re: [PATCH 1/3] [PATCH 1/3] xfs: remove XFS_MOUNT_NO_PERCPU_SB Message-ID: <20100929112920.GO5665@dastard> References: <20100929072221.583672974@bombadil.infradead.org> <20100929072237.865681186@bombadil.infradead.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20100929072237.865681186@bombadil.infradead.org> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Christoph Hellwig Cc: xfs@oss.sgi.com On Wed, Sep 29, 2010 at 03:22:22AM -0400, Christoph Hellwig wrote: > Fail the mount if we can't allocate memory for the per-CPU counters. > This is consistent with how we handle everything else in the mount > path and makes the superblock counter modification a lot simpler. > > Signed-off-by: Christoph Hellwig Looks good. I had an "XXX: kill XFS_MOUNT_NO_PERCPU_SB?" in my patch, so no complaints about this from me. Reviewed-by: Dave Chinner Cheers, Dave. -- Dave Chinner david@fromorbit.com _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs