From: Christoph Hellwig <hch@infradead.org>
To: xfs@oss.sgi.com
Subject: [PATCH 2/7] xfs: fix the xfs_trans_committed
Date: Wed, 06 Oct 2010 14:41:13 -0400 [thread overview]
Message-ID: <20101006184125.617230666@localhost.localdomain> (raw)
In-Reply-To: 20101006184111.634126439@localhost.localdomain
[-- Attachment #1: xfs-fix-cb_func_prototype --]
[-- Type: text/plain, Size: 1031 bytes --]
Use the correct prototype for xfs_trans_committed instead of casting it.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Index: xfs/fs/xfs/xfs_trans.c
===================================================================
--- xfs.orig/fs/xfs/xfs_trans.c 2010-10-06 11:10:13.774254205 +0200
+++ xfs/fs/xfs/xfs_trans.c 2010-10-06 11:13:16.145254205 +0200
@@ -1411,9 +1411,10 @@ xfs_trans_item_committed(
*/
STATIC void
xfs_trans_committed(
- struct xfs_trans *tp,
+ void *arg,
int abortflag)
{
+ struct xfs_trans *tp = arg;
struct xfs_log_item_desc *lidp, *next;
list_for_each_entry_safe(lidp, next, &tp->t_items, lid_trans) {
@@ -1543,7 +1544,7 @@ xfs_trans_commit_iclog(
* running in simulation mode (the log is explicitly turned
* off).
*/
- tp->t_logcb.cb_func = (void(*)(void*, int))xfs_trans_committed;
+ tp->t_logcb.cb_func = xfs_trans_committed;
tp->t_logcb.cb_arg = tp;
/*
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-10-06 18:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-06 18:41 [PATCH 0/7] a couple of random cleanups Christoph Hellwig
2010-10-06 18:41 ` [PATCH 1/7] xfs: remove unused t_callback field in struct xfs_trans Christoph Hellwig
2010-10-07 20:24 ` Alex Elder
2010-10-06 18:41 ` Christoph Hellwig [this message]
2010-10-07 20:24 ` [PATCH 2/7] xfs: fix the xfs_trans_committed Alex Elder
2010-10-06 18:41 ` [PATCH 3/7] xfs: remove xfs_refcache.h Christoph Hellwig
2010-10-07 20:24 ` Alex Elder
2010-10-06 18:41 ` [PATCH 4/7] xfs: remove xfs_version.h Christoph Hellwig
2010-10-07 20:24 ` Alex Elder
2010-10-06 18:41 ` [PATCH 5/7] xfs: remove xfs_globals.h Christoph Hellwig
2010-10-07 20:24 ` Alex Elder
2010-10-06 18:41 ` [PATCH 6/7] xfs: remove xfs_cred.h Christoph Hellwig
2010-10-07 20:24 ` Alex Elder
2010-10-06 18:41 ` [PATCH 7/7] xfs: remove xfs_buf wrappers Christoph Hellwig
2010-10-07 20:24 ` Alex Elder
2010-10-07 20:49 ` [PATCH 0/7] a couple of random cleanups Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101006184125.617230666@localhost.localdomain \
--to=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox