From: Dave Chinner <david@fromorbit.com>
To: Alex Elder <aelder@sgi.com>
Cc: xfs@oss.sgi.com, Alain Renaud <arenaud@sgi.com>
Subject: Re: [PATCH] xfstests: Fix some file permission.
Date: Sun, 10 Oct 2010 12:57:23 +1100 [thread overview]
Message-ID: <20101010015723.GM4681@dastard> (raw)
In-Reply-To: <1286660111.5392.6.camel@doink>
On Sat, Oct 09, 2010 at 04:35:11PM -0500, Alex Elder wrote:
> On Thu, 2010-10-07 at 17:22 -0500, Alain Renaud wrote:
> > I notice that some of the test script do not have execute
> > permission. To be consistent I changed the permissions to be 755.
> > Can someone verify that this is valid.
> >
> > Thanks.
>
> This looks good to me but I'd like a second opinion,
> to make sure there's no reason any of these should
> be non-executable.
I don't think it matters. Consistency is good, though, and we've
taken patches like this in the past.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-10-10 1:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-07 22:22 [PATCH] xfstests: Fix some file permission Alain Renaud
2010-10-09 21:35 ` Alex Elder
2010-10-10 1:57 ` Dave Chinner [this message]
2010-10-10 8:05 ` Christoph Hellwig
2010-10-10 15:12 ` Alex Elder
2010-10-12 20:13 ` Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101010015723.GM4681@dastard \
--to=david@fromorbit.com \
--cc=aelder@sgi.com \
--cc=arenaud@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox