* [PATCH] xfstests: Fix some file permission.
@ 2010-10-07 22:22 Alain Renaud
2010-10-09 21:35 ` Alex Elder
0 siblings, 1 reply; 6+ messages in thread
From: Alain Renaud @ 2010-10-07 22:22 UTC (permalink / raw)
To: xfs
I notice that some of the test script do not have execute
permission. To be consistent I changed the permissions to be 755.
Can someone verify that this is valid.
Thanks.
Signed-off-by: Alain Renaud <arenaud@sgi.com>
---
0 files changed, 0 insertions(+), 0 deletions(-)
mode change 100644 => 100755 215
mode change 100644 => 100755 220
mode change 100644 => 100755 221
mode change 100644 => 100755 222
mode change 100644 => 100755 224
mode change 100644 => 100755 225
mode change 100644 => 100755 227
mode change 100644 => 100755 229
mode change 100644 => 100755 236
mode change 100644 => 100755 237
mode change 100644 => 100755 239
mode change 100644 => 100755 242
mode change 100644 => 100755 244
diff --git a/215 b/215
old mode 100644
new mode 100755
diff --git a/220 b/220
old mode 100644
new mode 100755
diff --git a/221 b/221
old mode 100644
new mode 100755
diff --git a/222 b/222
old mode 100644
new mode 100755
diff --git a/224 b/224
old mode 100644
new mode 100755
diff --git a/225 b/225
old mode 100644
new mode 100755
diff --git a/227 b/227
old mode 100644
new mode 100755
diff --git a/229 b/229
old mode 100644
new mode 100755
diff --git a/236 b/236
old mode 100644
new mode 100755
diff --git a/237 b/237
old mode 100644
new mode 100755
diff --git a/239 b/239
old mode 100644
new mode 100755
diff --git a/242 b/242
old mode 100644
new mode 100755
diff --git a/244 b/244
old mode 100644
new mode 100755
--
1.6.0.2
--
===============================================
Alain Renaud - Cluster File System Engineer
arenaud@sgi.com - SGI
===============================================
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] xfstests: Fix some file permission.
2010-10-07 22:22 [PATCH] xfstests: Fix some file permission Alain Renaud
@ 2010-10-09 21:35 ` Alex Elder
2010-10-10 1:57 ` Dave Chinner
0 siblings, 1 reply; 6+ messages in thread
From: Alex Elder @ 2010-10-09 21:35 UTC (permalink / raw)
To: Alain Renaud; +Cc: xfs
On Thu, 2010-10-07 at 17:22 -0500, Alain Renaud wrote:
> I notice that some of the test script do not have execute
> permission. To be consistent I changed the permissions to be 755.
> Can someone verify that this is valid.
>
> Thanks.
This looks good to me but I'd like a second opinion,
to make sure there's no reason any of these should
be non-executable.
-Alex
> Signed-off-by: Alain Renaud <arenaud@sgi.com>
> ---
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] xfstests: Fix some file permission.
2010-10-09 21:35 ` Alex Elder
@ 2010-10-10 1:57 ` Dave Chinner
2010-10-10 8:05 ` Christoph Hellwig
0 siblings, 1 reply; 6+ messages in thread
From: Dave Chinner @ 2010-10-10 1:57 UTC (permalink / raw)
To: Alex Elder; +Cc: xfs, Alain Renaud
On Sat, Oct 09, 2010 at 04:35:11PM -0500, Alex Elder wrote:
> On Thu, 2010-10-07 at 17:22 -0500, Alain Renaud wrote:
> > I notice that some of the test script do not have execute
> > permission. To be consistent I changed the permissions to be 755.
> > Can someone verify that this is valid.
> >
> > Thanks.
>
> This looks good to me but I'd like a second opinion,
> to make sure there's no reason any of these should
> be non-executable.
I don't think it matters. Consistency is good, though, and we've
taken patches like this in the past.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] xfstests: Fix some file permission.
2010-10-10 1:57 ` Dave Chinner
@ 2010-10-10 8:05 ` Christoph Hellwig
2010-10-10 15:12 ` Alex Elder
2010-10-12 20:13 ` Alex Elder
0 siblings, 2 replies; 6+ messages in thread
From: Christoph Hellwig @ 2010-10-10 8:05 UTC (permalink / raw)
To: Dave Chinner; +Cc: xfs, Alain Renaud, Alex Elder
On Sun, Oct 10, 2010 at 12:57:23PM +1100, Dave Chinner wrote:
> > This looks good to me but I'd like a second opinion,
> > to make sure there's no reason any of these should
> > be non-executable.
>
> I don't think it matters. Consistency is good, though, and we've
> taken patches like this in the past.
Yeah. Btw, I'm not sure git-am can apply the mode changes from a patch,
in the worst case you might have to do the chmod calls manually.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] xfstests: Fix some file permission.
2010-10-10 8:05 ` Christoph Hellwig
@ 2010-10-10 15:12 ` Alex Elder
2010-10-12 20:13 ` Alex Elder
1 sibling, 0 replies; 6+ messages in thread
From: Alex Elder @ 2010-10-10 15:12 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: Alain Renaud, xfs
On Sun, 2010-10-10 at 04:05 -0400, Christoph Hellwig wrote:
> On Sun, Oct 10, 2010 at 12:57:23PM +1100, Dave Chinner wrote:
> > > This looks good to me but I'd like a second opinion,
> > > to make sure there's no reason any of these should
> > > be non-executable.
> >
> > I don't think it matters. Consistency is good, though, and we've
> > taken patches like this in the past.
>
> Yeah. Btw, I'm not sure git-am can apply the mode changes from a patch,
> in the worst case you might have to do the chmod calls manually.
>
OK. I'll figure out how to apply it. Thanks. -Alex
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] xfstests: Fix some file permission.
2010-10-10 8:05 ` Christoph Hellwig
2010-10-10 15:12 ` Alex Elder
@ 2010-10-12 20:13 ` Alex Elder
1 sibling, 0 replies; 6+ messages in thread
From: Alex Elder @ 2010-10-12 20:13 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: Alain Renaud, xfs
On Sun, 2010-10-10 at 04:05 -0400, Christoph Hellwig wrote:
> On Sun, Oct 10, 2010 at 12:57:23PM +1100, Dave Chinner wrote:
> > > This looks good to me but I'd like a second opinion,
> > > to make sure there's no reason any of these should
> > > be non-executable.
> >
> > I don't think it matters. Consistency is good, though, and we've
> > taken patches like this in the past.
>
> Yeah. Btw, I'm not sure git-am can apply the mode changes from a patch,
> in the worst case you might have to do the chmod calls manually.
>
Just a follow-up... "git am" *does* do the right thing with
a git-generated patch that describes changes to modes only.
(But "patch" and "quilt" of course just think it's garbage.)
I've committed this change to the xfstests-dev tree on kernel.org
and will push it out to oss next time I update that tree (most
likely later this week).
-Alex
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-10-12 20:12 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-07 22:22 [PATCH] xfstests: Fix some file permission Alain Renaud
2010-10-09 21:35 ` Alex Elder
2010-10-10 1:57 ` Dave Chinner
2010-10-10 8:05 ` Christoph Hellwig
2010-10-10 15:12 ` Alex Elder
2010-10-12 20:13 ` Alex Elder
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox