From: Christoph Hellwig <hch@infradead.org>
To: xfs@oss.sgi.com
Subject: [PATCH 3/4] xfstests: fix quota detection
Date: Fri, 15 Oct 2010 18:29:13 -0400 [thread overview]
Message-ID: <20101015222913.GC3781@infradead.org> (raw)
In-Reply-To: <20101015222820.GA3655@infradead.org>
Even if the kernel has quota support built in most filesystems still
don't support it. As there's no good way to find out if a filesystem
supports quotas hardcode the list of filesystems that do support
quotas.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Index: xfstests-dev/common.quota
===================================================================
--- xfstests-dev.orig/common.quota 2010-10-14 19:28:41.000000000 +0000
+++ xfstests-dev/common.quota 2010-10-14 19:33:45.000000000 +0000
@@ -27,11 +27,24 @@
_require_quota()
{
[ -n $QUOTA_PROG ] || _notrun "Quota user tools not installed"
- if [ $FSTYP = "xfs" ]; then
- [ -f /proc/fs/xfs/xqmstat ] || _notrun "Installed kernel does not support XFS quota"
- elif [ $FSTYP != "gfs2" ]; then
- [ -d /proc/sys/fs/quota ] || _notrun "Installed kernel does not support quota"
- fi
+
+ case $FSTYP in
+ ext2|ext3|ext4|reiserfs)
+ if [ ! -d /proc/sys/fs/quota ]; then
+ _notrun "Installed kernel does not support quotas"
+ fi
+ ;;
+ gfs2)
+ ;;
+ xfs)
+ if [ ! -f /proc/fs/xfs/xqmstat ]; then
+ _notrun "Installed kernel does not support XFS quotas"
+ fi
+ ;;
+ *)
+ _notrun "disk quotas not supported by this filesystem type: $FSTYP"
+ ;;
+ esac
}
#
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-10-15 22:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-15 22:28 [PATCH 0/4] xfstests fixes for hfsplus Christoph Hellwig
2010-10-15 22:28 ` [PATCH 1/4] xfstests: fix _require_acl Christoph Hellwig
2010-10-20 17:35 ` Alex Elder
2010-10-15 22:29 ` [PATCH 2/4] xfstests: add _require_attrs Christoph Hellwig
2010-10-20 18:03 ` Alex Elder
2010-10-21 5:02 ` Christoph Hellwig
2010-10-21 12:49 ` Alex Elder
2010-10-15 22:29 ` Christoph Hellwig [this message]
2010-10-20 17:36 ` [PATCH 3/4] xfstests: fix quota detection Alex Elder
2010-10-15 22:29 ` [PATCH 4/4] xfstests: handle filesystems without FIEMAP support Christoph Hellwig
2010-10-20 17:37 ` Alex Elder
2010-10-21 5:05 ` Christoph Hellwig
2010-10-21 5:35 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101015222913.GC3781@infradead.org \
--to=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox