From: Dave Chinner <david@fromorbit.com>
To: Alex Elder <aelder@sgi.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 00/11] xfstests: rework src/randholes.c
Date: Sat, 16 Oct 2010 16:13:13 +1100 [thread overview]
Message-ID: <20101016051313.GN4681@dastard> (raw)
In-Reply-To: <1287067771.2362.202.camel@doink>
On Thu, Oct 14, 2010 at 09:49:31AM -0500, Alex Elder wrote:
> Dave's recent "dynamic speculative EOF preallocation" changes
> caused test 008 to no longer produce the kinds of holes it was
> expecting to see, so it got me looking at the program it uses,
> "src/randholes.c".
>
> Since 008 is the only test using this program, it probably
> doesn't deserve the attention I gave it yesterday, but I've
> done the work so I might as well submit the series for
> review and get my changes in.
>
> The first patch in the series actually addresses two things
> that are bugs.
>
> The remaining 10 are just cleanup and refactoring changes.
> Other than two bug fix changes and one change in output
> when running in very-verbose mode, the patched code should
> be pretty much functionally identical to before.
I haven't really looked at the whole series closely, but nothing
stands out as a red flag. Seeing it's test code, it's probably
OK to go as is. The bug fixes look fine.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2010-10-16 5:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-14 14:49 [PATCH 00/11] xfstests: rework src/randholes.c Alex Elder
2010-10-16 5:13 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101016051313.GN4681@dastard \
--to=david@fromorbit.com \
--cc=aelder@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox